Issue 6820028: Mark single-argument inline constructors as 'explicit'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6820028: Mark single-argument inline constructors as 'explicit'. (Closed)

Created:
9 years, 8 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Mark single-argument inline constructors as 'explicit'. There is currently a bug in cpplint.py hiding this problem. R=sgjesse@chromium.org BUG=1304 TEST=none Committed: http://code.google.com/p/v8/source/detail?r=7567

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -19 lines)			Patch
M	include/v8.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/api.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/jsregexp.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/virtual-frame-mips.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	5 chunks	+8 lines, -5 lines	0 comments	Download
M	src/objects.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/objects-inl.h	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	src/property.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/scopeinfo.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM - how about the bug in cpplint.py?