Do not rely on uniquiness of pthread_t

src/v8threads.h

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 25 matching lines @@
  public:
   // Returns NULL after the last one.
   ThreadState* Next();
 
   enum List {FREE_LIST, IN_USE_LIST};
 
   void LinkInto(List list);
   void Unlink();
 
   // Id of thread.
-  void set_id(int id) { id_ = id; }
-  int id() { return id_; }
+  void set_id(ThreadId id) { id_ = id; }
+  ThreadId id() { return id_; }
 
   // Should the thread be terminated when it is restored?
   bool terminate_on_restore() { return terminate_on_restore_; }
   void set_terminate_on_restore(bool terminate_on_restore) {
     terminate_on_restore_ = terminate_on_restore;
   }
 
   // Get data area for archiving a thread.
   char* data() { return data_; }
  private:
   explicit ThreadState(ThreadManager* thread_manager);
 
   void AllocateSpace();
 
-  int id_;
+  ThreadId id_;
   bool terminate_on_restore_;
   char* data_;
   ThreadState* next_;
   ThreadState* previous_;
 
   ThreadManager* thread_manager_;
 
   friend class ThreadManager;
 };
 
 
 // Defined in top.h
 class ThreadLocalTop;
 
 
 class ThreadVisitor {
  public:
   // ThreadLocalTop may be only available during this call.
   virtual void VisitThread(Isolate* isolate, ThreadLocalTop* top) = 0;
 
  protected:
   virtual ~ThreadVisitor() {}
 };
 

[Vitaly Repeshko, 2011/04/11 19:28:52]

Only two-blank lines are needed here.

 
+
 class ThreadManager {
  public:
   void Lock();
   void Unlock();
 
   void ArchiveThread();
   bool RestoreThread();
   void FreeThreadResources();
   bool IsArchived();
 
   void Iterate(ObjectVisitor* v);
   void IterateArchivedThreads(ThreadVisitor* v);
-  bool IsLockedByCurrentThread() { return mutex_owner_.IsSelf(); }
+  bool IsLockedByCurrentThread() {
+    return mutex_owner_.Equals(ThreadId::Current());
+  }
 
-  int CurrentId();
+  ThreadId CurrentId();
 
-  void TerminateExecution(int thread_id);
+  void TerminateExecution(ThreadId thread_id);
 
   // Iterate over in-use states.
   ThreadState* FirstThreadStateInUse();
   ThreadState* GetFreeThreadState();
 
-  static const int kInvalidId = -1;
  private:
   ThreadManager();
   ~ThreadManager();
 
   void EagerlyArchiveThread();
 
   Mutex* mutex_;
-  ThreadHandle mutex_owner_;
-  ThreadHandle lazily_archived_thread_;
+  ThreadId mutex_owner_;
+  ThreadId lazily_archived_thread_;
   ThreadState* lazily_archived_thread_state_;
 
   // In the following two lists there is always at least one object on the list.
   // The first object is a flying anchor that is only there to simplify linking
   // and unlinking.
   // Head of linked list of free states.
   ThreadState* free_anchor_;
   // Head of linked list of states in use.
   ThreadState* in_use_anchor_;
 
@@ skipping 25 matching lines @@
 
   void Run();
 
   bool keep_going_;
   int sleep_ms_;
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_V8THREADS_H_