Report stack overflow exceptions to V8 message listeners

src/top.cc

Index: src/top.cc
===================================================================
--- src/top.cc	(revision 7547)
+++ src/top.cc	(working copy)
@@ -828,7 +828,8 @@
       thread_local_top()->has_pending_message_ = false;
       if (thread_local_top()->pending_message_ != NULL) {
         MessageHandler::ReportMessage(thread_local_top()->pending_message_);
-      } else if (!thread_local_top()->pending_message_obj_->IsTheHole()) {
+      }
+      if (!thread_local_top()->pending_message_obj_->IsTheHole()) {

[antonm, 2011/04/07 18:53:32]

sorry for popping up, but maybe stack overflow exception should probably set
pending_message_ and pending_message_obj_?

I am just concerned that we now can report a message more than once, is it fine?

[yurys, 2011/04/08 07:51:42]

MessageHandler::ReportMessage(const char*) just prints the message to system
console and has nothing to do with the V8 listeners. I'd suggest us remove
MessageHandler::ReportMessage(const char*) method along with the
pending_message_ field since for all pending_messages_ there will be
corresponding pending_message_obj_ anyway which means that the message will be
reported to the V8 embedder which can decide whether to dump it to the console
or handle in a more intelligent way.

         Handle<Object> message_obj(thread_local_top()->pending_message_obj_);
         if (thread_local_top()->pending_message_script_ != NULL) {
           Handle<Script> script(thread_local_top()->pending_message_script_);