Report stack overflow exceptions to V8 message listeners

src/top.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 810 matching lines @@
       try_catch_handler()->exception_ = thread_local_top()->pending_exception_;
       if (!thread_local_top()->pending_message_obj_->IsTheHole()) {
         try_catch_handler()->message_ =
             thread_local_top()->pending_message_obj_;
       }
     }
     if (thread_local_top()->has_pending_message_) {
       thread_local_top()->has_pending_message_ = false;
       if (thread_local_top()->pending_message_ != NULL) {
         MessageHandler::ReportMessage(thread_local_top()->pending_message_);
-      } else if (!thread_local_top()->pending_message_obj_->IsTheHole()) {
+      }
+      if (!thread_local_top()->pending_message_obj_->IsTheHole()) {

[antonm, 2011/04/07 18:53:32]

sorry for popping up, but maybe stack overflow exception should probably set
pending_message_ and pending_message_obj_?

I am just concerned that we now can report a message more than once, is it fine?

[yurys, 2011/04/08 07:51:42]

MessageHandler::ReportMessage(const char*) just prints the message to system
console and has nothing to do with the V8 listeners. I'd suggest us remove
MessageHandler::ReportMessage(const char*) method along with the
pending_message_ field since for all pending_messages_ there will be
corresponding pending_message_obj_ anyway which means that the message will be
reported to the V8 embedder which can decide whether to dump it to the console
or handle in a more intelligent way.

         Handle<Object> message_obj(thread_local_top()->pending_message_obj_);
         if (thread_local_top()->pending_message_script_ != NULL) {
           Handle<Script> script(thread_local_top()->pending_message_script_);
           int start_pos = thread_local_top()->pending_message_start_pos_;
           int end_pos = thread_local_top()->pending_message_end_pos_;
           MessageLocation location(script, start_pos, end_pos);
           MessageHandler::ReportMessage(&location, message_obj);
         } else {
           MessageHandler::ReportMessage(NULL, message_obj);
         }
@@ skipping 132 matching lines @@
   thread_local_top()->simulator_ = Simulator::current(this);
 #endif
 #endif
   if (RuntimeProfiler::IsEnabled() && current_vm_state() == JS) {
     RuntimeProfiler::IsolateEnteredJS(this);
   }
   return from + sizeof(ThreadLocalTop);
 }
 
 } }  // namespace v8::internal