Report stack overflow exceptions to V8 message listeners

Report stack overflow exceptions to V8 message listeners

Stack overflow exceptions like other JavaScript exceptions should be reported to listeners added via V8::AddMessageListener
Committed: http://code.google.com/p/v8/source/detail?r=7553

[antonm, 2011-04-07 18:53:32]

http://codereview.chromium.org/6816021/diff/1/src/top.cc
File src/top.cc (right):

http://codereview.chromium.org/6816021/diff/1/src/top.cc#newcode832
src/top.cc:832: if (!thread_local_top()->pending_message_obj_->IsTheHole()) {
sorry for popping up, but maybe stack overflow exception should probably set
pending_message_ and pending_message_obj_?

I am just concerned that we now can report a message more than once, is it fine?

[yurys, 2011-04-08 07:51:41]

http://codereview.chromium.org/6816021/diff/1/src/top.cc
File src/top.cc (right):

http://codereview.chromium.org/6816021/diff/1/src/top.cc#newcode832
src/top.cc:832: if (!thread_local_top()->pending_message_obj_->IsTheHole()) {
On 2011/04/07 18:53:32, antonm wrote:
> sorry for popping up, but maybe stack overflow exception should probably set
> pending_message_ and pending_message_obj_?
> 
> I am just concerned that we now can report a message more than once, is it
fine?

MessageHandler::ReportMessage(const char*) just prints the message to system
console and has nothing to do with the V8 listeners. I'd suggest us remove
MessageHandler::ReportMessage(const char*) method along with the
pending_message_ field since for all pending_messages_ there will be
corresponding pending_message_obj_ anyway which means that the message will be
reported to the V8 embedder which can decide whether to dump it to the console
or handle in a more intelligent way.

[yurys, 2011-04-08 08:37:28]

I removed ReportMessage(const char*) completely, please take a look.

[antonm, 2011-04-08 09:36:17]

Nice.  Off you go, ol' code.  LGTM.