Issue 6816019: Enable force tree closure.

Issue 6816019: Enable force tree closure. (Closed)

Created:
9 years, 8 months ago by ericli

Modified:
9 years, 7 months ago

Reviewers:
Dale Curtis, DaleCurtis

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org:9222/autotest.git@master

Visibility:
Public.

Description

Enable force tree closure. Change-Id: Idab5d3a07a4e88fe47b83b6ac12a21ee2b18da5b BUG=None TEST=manual tested Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=41bb2aa

Patch Set 4 : patch #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -12 lines)			Patch
	M	utils/set_tree_status.py	View	1 2 3	3 chunks	+18 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dale Curtis

http://codereview.chromium.org/6816019/diff/4002/utils/set_tree_status.py File utils/set_tree_status.py (right): http://codereview.chromium.org/6816019/diff/4002/utils/set_tree_status.py#newcode46 utils/set_tree_status.py:46: try: No need to catch anything here really, the ...

9 years, 8 months ago (2011-04-07 18:01:33 UTC) #3

ericli

9 years, 8 months ago (2011-04-07 18:08:28 UTC) #4

Dale Curtis

9 years, 8 months ago (2011-04-07 19:03:19 UTC) #5

LGTM

On 2011/04/07 18:08:28, ericli wrote:
> http://codereview.chromium.org/6816019/diff/4002/utils/set_tree_status.py
> File utils/set_tree_status.py (right):
> 
>
http://codereview.chromium.org/6816019/diff/4002/utils/set_tree_status.py#new...
> utils/set_tree_status.py:46: try:
> On 2011/04/07 18:01:33, Dale Curtis wrote:
> > No need to catch anything here really, the exception will result in a
non-zero
> > exit code already. It was fine the way you had before.
> > 
> > You also haven't imported logging so this will fail.
> 
> Done.
> 
>
http://codereview.chromium.org/6816019/diff/4002/utils/set_tree_status.py#new...
> utils/set_tree_status.py:59: parser = optparse.OptionParser("%prog [options]
> quoted_messages")
> On 2011/04/07 18:01:33, Dale Curtis wrote:
> > quoted_message
> 
> Done.
> 
>
http://codereview.chromium.org/6816019/diff/4002/utils/set_tree_status.py#new...
> utils/set_tree_status.py:63: help='Force closing tree action.')
> On 2011/04/07 18:01:33, Dale Curtis wrote:
> > Test should be 'Don't close the tree if it's already closed.'
> 
> Done.

Expand Messages | Collapse Messages