README - Issue 6816010: Add a README for Valgrind binaries.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: README

Issue 6816010: Add a README for Valgrind binaries. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/third_party/valgrind/bin/

Patch Set: '' Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 This directory contains pre-built valgrind binaries which can be used with

	2 NaCl. They can be updated from the ThreadSanitizer buildbot:

	3 wget http://build.chromium.org/p/client.tsan/binaries/memcheck-r${REV}-amd64 only-linux-self-contained.sh -O memcheck

	4 wget http://build.chromium.org/p/client.tsan/binaries/tsan-r${REV}-amd64only -linux-self-contained.sh -O tsan

	5

	6 Source code for these tools is available at:

	7 http://code.google.com/p/valgrind-variant

	8 http://code.google.com/p/data-race-test

	9

	10 To find out the exact revision of the binaries, see "svn log".
	Mark Seaborn 2011/04/13 06:26:48 OK, if I do that, I find: OK, if I do that, I find: Show quoted text > r3497 \| eugenis@google.com \| 2010-10-19 04:30:44 -0700 (Tue, 19 Oct 2010) \| 5 lines > > Update memcheck and tsan binaries to tsan@2519 + valgrind-variant@62+68+71. I don't understand what "@62+68+71" means. Does it mean r62 with r68 and r71 cherry-picked? (That seems unlikely if it is build automatically by a buildbot.) It's not immediately obvious that tsan@2519 refers to the directory http://data-race-test.googlecode.com/svn/trunk/tsan/. It wouldn't hurt to spell this out. Evgeniy Stepanov 2011/04/13 12:48:20 Yes, the current binary was built manually with a Show quoted text On 2011/04/13 06:26:48, Mark Seaborn wrote: > OK, if I do that, I find: > > > r3497 \| mailto:eugenis@google.com \| 2010-10-19 04:30:44 -0700 (Tue, 19 Oct 2010) \| 5 > lines > > > > Update memcheck and tsan binaries to tsan@2519 + valgrind-variant@62+68+71. > > I don't understand what "@62+68+71" means. Does it mean r62 with r68 and r71 > cherry-picked? (That seems unlikely if it is build automatically by a > buildbot.) Yes, the current binary was built manually with a couple of cherry-picked changes. It should not happen in the future. Newest binaries from the buildbot should be fine. Show quoted text > It's not immediately obvious that tsan@2519 refers to the directory > http://data-race-test.googlecode.com/svn/trunk/tsan/. It wouldn't hurt to spell > this out. Yes, ideally commit messages should look like "Update memcheck and tsan binaries to http://data-race-test.googlecode.com/svn/trunk@rXXXX." Valgrind revision is pinned in third_party/update_valgrind.sh script. Do you want me to fix the comment by changing SVN history (not sure if that's allowed in NaCl)? I plan to work on NaCl/DSO support in Valgrind and TSan in Q2. I'll update the binaries with a proper comment then.
	11

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »