Issue 6814045: Linux: fix net_unittests failures on Gentoo Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6814045: Linux: fix net_unittests failures on Gentoo Linux (Closed)

Created:
9 years, 8 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
wtc, Ryan Sleevi

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Linux: fix net_unittests failures on Gentoo Linux tlslite does some autodetection which when m2crypto is installed and importable is more strict when parsing certificate files. This CL makes our certificate files acceptable by both the more strict and more lenient versions of code used by tlslite. Swap the certificate and private key in [ok|expired]_cert.pem, so that s.startswith() will return true for OpenSSL_RSAKey. tlslite.X509 uses s.find() to locate the BEGIN CERTIFICATE, so it should be unaffected. For more info see http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/903f65ad685da9b2# Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81218

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -30 lines)			Patch
	M	net/data/ssl/certificates/expired_cert.pem	View		2 chunks	+15 lines, -15 lines	0 comments	Download
	M	net/data/ssl/certificates/ok_cert.pem	View		2 chunks	+15 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

I have just tested it on a Gentoo Linux machine with bundled tlslite (with the ...

9 years, 8 months ago (2011-04-08 16:21:11 UTC) #1

wtc

9 years, 8 months ago (2011-04-08 19:18:09 UTC) #2

LGTM.

The CL's description should clearly say we change to list
the RSA private key before the certificate in the PEM files.

Expand Messages | Collapse Messages