Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5237)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 6814029: Revert 80519 - Move favicon from TabContents to TabContentsWrapper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
===================================================================
--- chrome/browser/ui/views/location_bar/location_bar_view.cc (revision 80859)
+++ chrome/browser/ui/views/location_bar/location_bar_view.cc (working copy)
@@ -17,7 +17,6 @@
#include "chrome/browser/defaults.h"
#include "chrome/browser/extensions/extension_browser_event_router.h"
#include "chrome/browser/extensions/extension_service.h"
-#include "chrome/browser/favicon_tab_helper.h"
#include "chrome/browser/instant/instant_controller.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/search_engines/template_url.h"
@@ -833,7 +832,7 @@
}
SkBitmap LocationBarView::GetFavicon() const {
- return delegate_->GetTabContentsWrapper()->favicon_tab_helper()->GetFavicon();
+ return GetTabContentsFromDelegate(delegate_)->GetFavicon();
}
string16 LocationBarView::GetTitle() const {
@@ -844,7 +843,7 @@
return delegate_->GetInstant();
}
-TabContentsWrapper* LocationBarView::GetTabContentsWrapper() const {
+TabContentsWrapper* LocationBarView::GetTabContentsWrapper() {
return delegate_->GetTabContentsWrapper();
}
@@ -1035,13 +1034,11 @@
DCHECK_NE(GetDragOperationsForView(sender, press_pt),
ui::DragDropTypes::DRAG_NONE);
- TabContentsWrapper* tab_contents = delegate_->GetTabContentsWrapper();
+ TabContents* tab_contents = GetTabContentsFromDelegate(delegate_);
DCHECK(tab_contents);
- drag_utils::SetURLAndDragImage(
- tab_contents->tab_contents()->GetURL(),
- UTF16ToWideHack(tab_contents->tab_contents()->GetTitle()),
- tab_contents->favicon_tab_helper()->GetFavicon(),
- data);
+ drag_utils::SetURLAndDragImage(tab_contents->GetURL(),
+ UTF16ToWideHack(tab_contents->GetTitle()),
+ tab_contents->GetFavicon(), data);
}
int LocationBarView::GetDragOperationsForView(views::View* sender,
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.h ('k') | chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698