Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: chrome/browser/ui/views/hung_renderer_view.cc

Issue 6814029: Revert 80519 - Move favicon from TabContents to TabContentsWrapper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/hung_renderer_view.cc
===================================================================
--- chrome/browser/ui/views/hung_renderer_view.cc (revision 80859)
+++ chrome/browser/ui/views/hung_renderer_view.cc (working copy)
@@ -6,7 +6,6 @@
#include "base/i18n/rtl.h"
#include "base/utf_string_conversions.h"
-#include "chrome/browser/favicon_tab_helper.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
#include "chrome/common/chrome_constants.h"
@@ -56,7 +55,7 @@
virtual void GetGroupRangeForItem(int item, views::GroupRange* range);
private:
- typedef std::vector<TabContentsWrapper*> TabContentsVector;
+ typedef std::vector<TabContents*> TabContentsVector;
TabContentsVector tab_contentses_;
ui::TableModelObserver* observer_;
@@ -78,7 +77,7 @@
for (TabContentsIterator it; !it.done(); ++it) {
if (it->tab_contents()->GetRenderProcessHost() ==
hung_contents->GetRenderProcessHost())
- tab_contentses_.push_back(*it);
+ tab_contentses_.push_back((*it)->tab_contents());
}
// The world is different.
if (observer_)
@@ -94,7 +93,7 @@
string16 HungPagesTableModel::GetText(int row, int column_id) {
DCHECK(row >= 0 && row < RowCount());
- string16 title = tab_contentses_[row]->tab_contents()->GetTitle();
+ string16 title = tab_contentses_[row]->GetTitle();
if (title.empty())
title = TabContentsWrapper::GetDefaultTitle();
// TODO(xji): Consider adding a special case if the title text is a URL,
@@ -106,7 +105,7 @@
SkBitmap HungPagesTableModel::GetIcon(int row) {
DCHECK(row >= 0 && row < RowCount());
- return tab_contentses_.at(row)->favicon_tab_helper()->GetFavicon();
+ return tab_contentses_.at(row)->GetFavicon();
}
void HungPagesTableModel::SetObserver(ui::TableModelObserver* observer) {
« no previous file with comments | « chrome/browser/ui/views/create_application_shortcut_view.cc ('k') | chrome/browser/ui/views/location_bar/location_bar_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698