Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5565)

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 6814029: Revert 80519 - Move favicon from TabContents to TabContentsWrapper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_manager.cc
===================================================================
--- chrome/browser/prerender/prerender_manager.cc (revision 80859)
+++ chrome/browser/prerender/prerender_manager.cc (working copy)
@@ -9,11 +9,9 @@
#include "base/metrics/histogram.h"
#include "base/time.h"
#include "base/utf_string_conversions.h"
-#include "chrome/browser/favicon_tab_helper.h"
#include "chrome/browser/prerender/prerender_contents.h"
#include "chrome/browser/prerender/prerender_final_status.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
#include "chrome/common/render_messages.h"
#include "content/browser/browser_thread.h"
#include "content/browser/renderer_host/render_view_host.h"
@@ -339,12 +337,8 @@
tc->UpdateTitle(rvh, pc->page_id(), UTF16ToWideHack(title));
GURL icon_url = pc->icon_url();
- if (!icon_url.is_empty()) {
- // TODO(avi): move prerendering to use TCWs; remove this.
- TabContentsWrapper* wrapper =
- TabContentsWrapper::GetCurrentWrapperForContents(tc);
- wrapper->favicon_tab_helper()->OnUpdateFaviconURL(pc->page_id(), icon_url);
- }
+ if (!icon_url.is_empty())
+ tc->favicon_helper().OnUpdateFaviconURL(pc->page_id(), icon_url);
if (pc->has_stopped_loading())
tc->DidStopLoading();
Property changes on: chrome/browser/prerender/prerender_manager.cc
___________________________________________________________________
Added: svn:mergeinfo
« no previous file with comments | « chrome/browser/favicon_tab_helper.cc ('k') | chrome/browser/task_manager/task_manager_resource_providers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698