Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: chrome/browser/ui/tab_contents/tab_contents_wrapper.h

Issue 6814029: Revert 80519 - Move favicon from TabContents to TabContentsWrapper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_ 5 #ifndef CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_
6 #define CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_ 6 #define CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 13 matching lines...) Expand all
24 class PrintPreviewMessageHandler; 24 class PrintPreviewMessageHandler;
25 } 25 }
26 26
27 class AutocompleteHistoryManager; 27 class AutocompleteHistoryManager;
28 class AutofillManager; 28 class AutofillManager;
29 class AutomationTabHelper; 29 class AutomationTabHelper;
30 class DevToolsObserver; 30 class DevToolsObserver;
31 class Extension; 31 class Extension;
32 class ExtensionMessageObserver; 32 class ExtensionMessageObserver;
33 class ExtensionTabHelper; 33 class ExtensionTabHelper;
34 class FaviconTabHelper;
35 class FileSelectObserver; 34 class FileSelectObserver;
36 class FindTabHelper; 35 class FindTabHelper;
37 class NavigationController; 36 class NavigationController;
38 class PasswordManager; 37 class PasswordManager;
39 class PasswordManagerDelegate; 38 class PasswordManagerDelegate;
40 class SearchEngineTabHelper; 39 class SearchEngineTabHelper;
41 class TabContentsWrapperDelegate; 40 class TabContentsWrapperDelegate;
42 41
43 // Wraps TabContents and all of its supporting objects in order to control 42 // Wraps TabContents and all of its supporting objects in order to control
44 // their ownership and lifetime, while allowing TabContents to remain generic 43 // their ownership and lifetime, while allowing TabContents to remain generic
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 102
104 // Used only for testing/automation. 103 // Used only for testing/automation.
105 AutomationTabHelper* automation_tab_helper() { 104 AutomationTabHelper* automation_tab_helper() {
106 return automation_tab_helper_.get(); 105 return automation_tab_helper_.get();
107 } 106 }
108 107
109 ExtensionTabHelper* extension_tab_helper() { 108 ExtensionTabHelper* extension_tab_helper() {
110 return extension_tab_helper_.get(); 109 return extension_tab_helper_.get();
111 } 110 }
112 111
113 FaviconTabHelper* favicon_tab_helper() { return favicon_tab_helper_.get(); }
114
115 FindTabHelper* find_tab_helper() { return find_tab_helper_.get(); } 112 FindTabHelper* find_tab_helper() { return find_tab_helper_.get(); }
116 113
117 PasswordManager* password_manager() { return password_manager_.get(); } 114 PasswordManager* password_manager() { return password_manager_.get(); }
118 115
119 SearchEngineTabHelper* search_engine_tab_helper() { 116 SearchEngineTabHelper* search_engine_tab_helper() {
120 return search_engine_tab_helper_.get(); 117 return search_engine_tab_helper_.get();
121 } 118 }
122 119
123 printing::PrintViewManager* print_view_manager() { 120 printing::PrintViewManager* print_view_manager() {
124 return print_view_manager_.get(); 121 return print_view_manager_.get();
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 bool is_starred_; 164 bool is_starred_;
168 165
169 // Tab Helpers --------------------------------------------------------------- 166 // Tab Helpers ---------------------------------------------------------------
170 // (These provide API for callers and have a getter function listed in the 167 // (These provide API for callers and have a getter function listed in the
171 // "Tab Helpers" section in the member functions area, above.) 168 // "Tab Helpers" section in the member functions area, above.)
172 169
173 scoped_ptr<AutocompleteHistoryManager> autocomplete_history_manager_; 170 scoped_ptr<AutocompleteHistoryManager> autocomplete_history_manager_;
174 scoped_ptr<AutofillManager> autofill_manager_; 171 scoped_ptr<AutofillManager> autofill_manager_;
175 scoped_ptr<AutomationTabHelper> automation_tab_helper_; 172 scoped_ptr<AutomationTabHelper> automation_tab_helper_;
176 scoped_ptr<ExtensionTabHelper> extension_tab_helper_; 173 scoped_ptr<ExtensionTabHelper> extension_tab_helper_;
177 scoped_ptr<FaviconTabHelper> favicon_tab_helper_;
178 scoped_ptr<FindTabHelper> find_tab_helper_; 174 scoped_ptr<FindTabHelper> find_tab_helper_;
179 175
180 // PasswordManager and its delegate. The delegate must outlive the manager, 176 // PasswordManager and its delegate. The delegate must outlive the manager,
181 // per documentation in password_manager.h. 177 // per documentation in password_manager.h.
182 scoped_ptr<PasswordManagerDelegate> password_manager_delegate_; 178 scoped_ptr<PasswordManagerDelegate> password_manager_delegate_;
183 scoped_ptr<PasswordManager> password_manager_; 179 scoped_ptr<PasswordManager> password_manager_;
184 180
185 scoped_ptr<SearchEngineTabHelper> search_engine_tab_helper_; 181 scoped_ptr<SearchEngineTabHelper> search_engine_tab_helper_;
186 182
187 // Handles print job for this contents. 183 // Handles print job for this contents.
(...skipping 13 matching lines...) Expand all
201 197
202 // The supporting objects need to outlive the TabContents dtor (as they may 198 // The supporting objects need to outlive the TabContents dtor (as they may
203 // be called upon during its execution). As a result, this must come last 199 // be called upon during its execution). As a result, this must come last
204 // in the list. 200 // in the list.
205 scoped_ptr<TabContents> tab_contents_; 201 scoped_ptr<TabContents> tab_contents_;
206 202
207 DISALLOW_COPY_AND_ASSIGN(TabContentsWrapper); 203 DISALLOW_COPY_AND_ASSIGN(TabContentsWrapper);
208 }; 204 };
209 205
210 #endif // CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_ 206 #endif // CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc ('k') | chrome/browser/ui/tab_contents/tab_contents_wrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698