Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Side by Side Diff: chrome/browser/ui/cocoa/hung_renderer_controller.mm

Issue 6814029: Revert 80519 - Move favicon from TabContents to TabContentsWrapper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/hung_renderer_controller.h" 5 #import "chrome/browser/ui/cocoa/hung_renderer_controller.h"
6 6
7 #import <Cocoa/Cocoa.h> 7 #import <Cocoa/Cocoa.h>
8 8
9 #include "base/mac/mac_util.h" 9 #include "base/mac/mac_util.h"
10 #include "base/process_util.h" 10 #include "base/process_util.h"
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 for (TabContentsIterator it; !it.done(); ++it) { 141 for (TabContentsIterator it; !it.done(); ++it) {
142 if (it->tab_contents()->GetRenderProcessHost() == 142 if (it->tab_contents()->GetRenderProcessHost() ==
143 hungContents_->GetRenderProcessHost()) { 143 hungContents_->GetRenderProcessHost()) {
144 string16 title = (*it)->tab_contents()->GetTitle(); 144 string16 title = (*it)->tab_contents()->GetTitle();
145 if (title.empty()) 145 if (title.empty())
146 title = TabContentsWrapper::GetDefaultTitle(); 146 title = TabContentsWrapper::GetDefaultTitle();
147 [titles addObject:base::SysUTF16ToNSString(title)]; 147 [titles addObject:base::SysUTF16ToNSString(title)];
148 148
149 // TabContents can return a null SkBitmap if it has no favicon. If this 149 // TabContents can return a null SkBitmap if it has no favicon. If this
150 // happens, use the default favicon. 150 // happens, use the default favicon.
151 const SkBitmap& bitmap = it->favicon_tab_helper()->GetFavicon(); 151 const SkBitmap& bitmap = it->tab_contents()->GetFavicon();
152 if (!bitmap.isNull()) { 152 if (!bitmap.isNull()) {
153 [favicons addObject:gfx::SkBitmapToNSImage(bitmap)]; 153 [favicons addObject:gfx::SkBitmapToNSImage(bitmap)];
154 } else { 154 } else {
155 ResourceBundle& rb = ResourceBundle::GetSharedInstance(); 155 ResourceBundle& rb = ResourceBundle::GetSharedInstance();
156 [favicons addObject:rb.GetNativeImageNamed(IDR_DEFAULT_FAVICON)]; 156 [favicons addObject:rb.GetNativeImageNamed(IDR_DEFAULT_FAVICON)];
157 } 157 }
158 } 158 }
159 } 159 }
160 hungTitles_.reset([titles copy]); 160 hungTitles_.reset([titles copy]);
161 hungFavicons_.reset([favicons copy]); 161 hungFavicons_.reset([favicons copy]);
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 [g_instance showForTabContents:contents]; 197 [g_instance showForTabContents:contents];
198 } 198 }
199 } 199 }
200 200
201 void HideHungRendererDialog(TabContents* contents) { 201 void HideHungRendererDialog(TabContents* contents) {
202 if (!logging::DialogsAreSuppressed() && g_instance) 202 if (!logging::DialogsAreSuppressed() && g_instance)
203 [g_instance endForTabContents:contents]; 203 [g_instance endForTabContents:contents];
204 } 204 }
205 205
206 } // namespace browser 206 } // namespace browser
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698