Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: chrome/browser/chromeos/wm_overview_controller.cc

Issue 6814029: Revert 80519 - Move favicon from TabContents to TabContentsWrapper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
Property Changes:
Added: svn:mergeinfo
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/wm_overview_controller.h" 5 #include "chrome/browser/chromeos/wm_overview_controller.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/memory/linked_ptr.h" 10 #include "base/memory/linked_ptr.h"
11 #include "chrome/browser/browser_process.h" 11 #include "chrome/browser/browser_process.h"
12 #include "chrome/browser/chromeos/wm_ipc.h" 12 #include "chrome/browser/chromeos/wm_ipc.h"
13 #include "chrome/browser/chromeos/wm_overview_favicon.h" 13 #include "chrome/browser/chromeos/wm_overview_favicon.h"
14 #include "chrome/browser/chromeos/wm_overview_snapshot.h" 14 #include "chrome/browser/chromeos/wm_overview_snapshot.h"
15 #include "chrome/browser/chromeos/wm_overview_title.h" 15 #include "chrome/browser/chromeos/wm_overview_title.h"
16 #include "chrome/browser/favicon_tab_helper.h"
17 #include "chrome/browser/tab_contents/thumbnail_generator.h" 16 #include "chrome/browser/tab_contents/thumbnail_generator.h"
18 #include "chrome/browser/tabs/tab_strip_model.h" 17 #include "chrome/browser/tabs/tab_strip_model.h"
19 #include "chrome/browser/ui/browser.h" 18 #include "chrome/browser/ui/browser.h"
20 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" 19 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
21 #include "chrome/browser/ui/views/frame/browser_view.h" 20 #include "chrome/browser/ui/views/frame/browser_view.h"
22 #include "content/browser/renderer_host/render_view_host.h" 21 #include "content/browser/renderer_host/render_view_host.h"
23 #include "content/browser/renderer_host/render_widget_host.h" 22 #include "content/browser/renderer_host/render_widget_host.h"
24 #include "content/browser/renderer_host/render_widget_host_view.h" 23 #include "content/browser/renderer_host/render_widget_host_view.h"
25 #include "content/browser/tab_contents/tab_contents.h" 24 #include "content/browser/tab_contents/tab_contents.h"
26 #include "content/browser/tab_contents/tab_contents_view.h" 25 #include "content/browser/tab_contents/tab_contents_view.h"
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 } 232 }
234 233
235 void BrowserListener::TabChangedAt( 234 void BrowserListener::TabChangedAt(
236 TabContentsWrapper* contents, 235 TabContentsWrapper* contents,
237 int index, 236 int index,
238 TabStripModelObserver::TabChangeType change_type) { 237 TabStripModelObserver::TabChangeType change_type) {
239 if (change_type != TabStripModelObserver::LOADING_ONLY) { 238 if (change_type != TabStripModelObserver::LOADING_ONLY) {
240 snapshots_[index].title->SetTitle(contents->tab_contents()->GetTitle()); 239 snapshots_[index].title->SetTitle(contents->tab_contents()->GetTitle());
241 snapshots_[index].title->SetUrl(contents->tab_contents()->GetURL()); 240 snapshots_[index].title->SetUrl(contents->tab_contents()->GetURL());
242 snapshots_[index].favicon->SetFavicon( 241 snapshots_[index].favicon->SetFavicon(
243 contents->favicon_tab_helper()->GetFavicon()); 242 contents->tab_contents()->GetFavicon());
244 if (change_type != TabStripModelObserver::TITLE_NOT_LOADING) 243 if (change_type != TabStripModelObserver::TITLE_NOT_LOADING)
245 MarkSnapshotAsDirty(index); 244 MarkSnapshotAsDirty(index);
246 } 245 }
247 } 246 }
248 247
249 void BrowserListener::TabStripEmpty() { 248 void BrowserListener::TabStripEmpty() {
250 snapshots_.clear(); 249 snapshots_.clear();
251 } 250 }
252 251
253 void BrowserListener::TabSelectedAt(TabContentsWrapper* old_contents, 252 void BrowserListener::TabSelectedAt(TabContentsWrapper* old_contents,
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 } 417 }
419 418
420 void BrowserListener::InsertSnapshot(int index) { 419 void BrowserListener::InsertSnapshot(int index) {
421 SnapshotNode node; 420 SnapshotNode node;
422 node.snapshot = new WmOverviewSnapshot; 421 node.snapshot = new WmOverviewSnapshot;
423 gfx::Size cell_size = CalculateCellSize(); 422 gfx::Size cell_size = CalculateCellSize();
424 node.snapshot->Init(cell_size, browser_, index); 423 node.snapshot->Init(cell_size, browser_, index);
425 424
426 node.favicon = new WmOverviewFavicon; 425 node.favicon = new WmOverviewFavicon;
427 node.favicon->Init(node.snapshot); 426 node.favicon->Init(node.snapshot);
428 node.favicon->SetFavicon( 427 node.favicon->SetFavicon(browser_->GetTabContentsAt(index)->GetFavicon());
429 browser_->GetTabContentsWrapperAt(index)->
430 favicon_tab_helper()->GetFavicon());
431 428
432 node.title = new WmOverviewTitle; 429 node.title = new WmOverviewTitle;
433 node.title->Init(gfx::Size(std::max(0, cell_size.width() - 430 node.title->Init(gfx::Size(std::max(0, cell_size.width() -
434 WmOverviewFavicon::kIconSize - 431 WmOverviewFavicon::kIconSize -
435 kFaviconPadding), 432 kFaviconPadding),
436 kTitleHeight), node.snapshot); 433 kTitleHeight), node.snapshot);
437 node.title->SetTitle(browser_->GetTabContentsAt(index)->GetTitle()); 434 node.title->SetTitle(browser_->GetTabContentsAt(index)->GetTitle());
438 435
439 snapshots_.insert(snapshots_.begin() + index, node); 436 snapshots_.insert(snapshots_.begin() + index, node);
440 node.snapshot->reload_snapshot(); 437 node.snapshot->reload_snapshot();
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
741 if (item.get() == NULL) { 738 if (item.get() == NULL) {
742 item = BrowserListenerVector::value_type( 739 item = BrowserListenerVector::value_type(
743 new BrowserListener(*iterator, this)); 740 new BrowserListener(*iterator, this));
744 } 741 }
745 listeners_.push_back(item); 742 listeners_.push_back(item);
746 ++iterator; 743 ++iterator;
747 } 744 }
748 } 745 }
749 746
750 } // namespace chromeos 747 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_edit_unittest.cc ('k') | chrome/browser/content_setting_bubble_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698