Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 6814016: Fix cow fixed array map check in optimized arm code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2392 matching lines...) Expand 10 before | Expand all | Expand 10 after
2403 2403
2404 __ ldr(result, FieldMemOperand(input, JSObject::kElementsOffset)); 2404 __ ldr(result, FieldMemOperand(input, JSObject::kElementsOffset));
2405 if (FLAG_debug_code) { 2405 if (FLAG_debug_code) {
2406 Label done; 2406 Label done;
2407 __ ldr(scratch, FieldMemOperand(result, HeapObject::kMapOffset)); 2407 __ ldr(scratch, FieldMemOperand(result, HeapObject::kMapOffset));
2408 __ LoadRoot(ip, Heap::kFixedArrayMapRootIndex); 2408 __ LoadRoot(ip, Heap::kFixedArrayMapRootIndex);
2409 __ cmp(scratch, ip); 2409 __ cmp(scratch, ip);
2410 __ b(eq, &done); 2410 __ b(eq, &done);
2411 __ LoadRoot(ip, Heap::kFixedCOWArrayMapRootIndex); 2411 __ LoadRoot(ip, Heap::kFixedCOWArrayMapRootIndex);
2412 __ cmp(scratch, ip); 2412 __ cmp(scratch, ip);
2413 __ b(eq, &done);
2413 __ ldr(scratch, FieldMemOperand(result, HeapObject::kMapOffset)); 2414 __ ldr(scratch, FieldMemOperand(result, HeapObject::kMapOffset));
2414 __ ldrb(scratch, FieldMemOperand(scratch, Map::kInstanceTypeOffset)); 2415 __ ldrb(scratch, FieldMemOperand(scratch, Map::kInstanceTypeOffset));
2415 __ sub(scratch, scratch, Operand(FIRST_EXTERNAL_ARRAY_TYPE)); 2416 __ sub(scratch, scratch, Operand(FIRST_EXTERNAL_ARRAY_TYPE));
2416 __ cmp(scratch, Operand(kExternalArrayTypeCount)); 2417 __ cmp(scratch, Operand(kExternalArrayTypeCount));
2417 __ Check(cc, "Check for fast elements failed."); 2418 __ Check(cc, "Check for fast elements failed.");
2418 __ bind(&done); 2419 __ bind(&done);
2419 } 2420 }
2420 } 2421 }
2421 2422
2422 2423
(...skipping 1780 matching lines...) Expand 10 before | Expand all | Expand 10 after
4203 ASSERT(!environment->HasBeenRegistered()); 4204 ASSERT(!environment->HasBeenRegistered());
4204 RegisterEnvironmentForDeoptimization(environment); 4205 RegisterEnvironmentForDeoptimization(environment);
4205 ASSERT(osr_pc_offset_ == -1); 4206 ASSERT(osr_pc_offset_ == -1);
4206 osr_pc_offset_ = masm()->pc_offset(); 4207 osr_pc_offset_ = masm()->pc_offset();
4207 } 4208 }
4208 4209
4209 4210
4210 #undef __ 4211 #undef __
4211 4212
4212 } } // namespace v8::internal 4213 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698