chrome/browser/desktop_notification_handler.cc - Issue 6813116: Revert 81277 - Profile shouldn't own DesktopNotificationService.DesktopNotificationService is now...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/desktop_notification_handler.cc

Issue 6813116: Revert 81277 - Profile shouldn't own DesktopNotificationService.DesktopNotificationService is now... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_notification_provider.cc ('k') | chrome/browser/extensions/notifications_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/desktop_notification_handler.cc

===================================================================

--- chrome/browser/desktop_notification_handler.cc (revision 81278)

+++ chrome/browser/desktop_notification_handler.cc (working copy)

@@ -5,7 +5,6 @@

#include "chrome/browser/desktop_notification_handler.h"

#include "chrome/browser/notifications/desktop_notification_service.h"

-#include "chrome/browser/notifications/desktop_notification_service_factory.h"

#include "chrome/browser/profiles/profile.h"

#include "content/browser/renderer_host/render_process_host.h"

#include "content/browser/renderer_host/render_view_host.h"

@@ -39,7 +38,7 @@

const DesktopNotificationHostMsg_Show_Params& params) {

RenderProcessHost* process = render_view_host()->process();

DesktopNotificationService* service =

- DesktopNotificationServiceFactory::GetForProfile(process->profile());

+ process->profile()->GetDesktopNotificationService();

service->ShowDesktopNotification(

params,

@@ -51,7 +50,7 @@

void DesktopNotificationHandler::OnCancel(int notification_id) {

RenderProcessHost* process = render_view_host()->process();

DesktopNotificationService* service =

- DesktopNotificationServiceFactory::GetForProfile(process->profile());

+ process->profile()->GetDesktopNotificationService();

service->CancelDesktopNotification(

process->id(),

@@ -68,7 +67,7 @@

RenderProcessHost* process = render_view_host()->process();

DesktopNotificationService* service =

- DesktopNotificationServiceFactory::GetForProfile(process->profile());

+ process->profile()->GetDesktopNotificationService();

service->RequestPermission(

source_origin, process->id(), routing_id(), callback_context, NULL);

}