Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6813116: Revert 81277 - Profile shouldn't own DesktopNotificationService.DesktopNotificationService is now... (Closed)

Created:
9 years, 8 months ago by Sigurður Ásgeirsson
Modified:
9 years, 7 months ago
Reviewers:
Torne
CC:
chromium-reviews, Avi (use Gerrit), idana, Raghu Simha, Erik does not do reviews, brettw-cc_chromium.org, jam, ncarter (slow), Aaron Boodman, pam+watch_chromium.org, tim (not reviewing), Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 81277 - Profile shouldn't own DesktopNotificationService.DesktopNotificationService is now owned byDesktopNotificationServiceFactory, using Profile as a key. This uses theProfileKeyedService infrastructure originally created forThemeServiceFactory.BUG=77155 TEST=existing testsReview URL: http://codereview.chromium.org/6803012 TBR=torne@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -196 lines) Patch
M chrome/browser/chromeos/notifications/balloon_view.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_notification_provider.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/desktop_notification_handler.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/notifications_apitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 2 chunks +2 lines, -5 lines 0 comments Download
D chrome/browser/notifications/desktop_notification_service_factory.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/notifications/desktop_notification_service_factory.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/notifications/notification_exceptions_table_model_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/notifications/notification_options_menu_model.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager_unittest.cc View 8 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_keyed_service_factory.h View 3 chunks +3 lines, -25 lines 0 comments Download
M chrome/browser/profiles/profile_keyed_service_factory.cc View 3 chunks +5 lines, -15 lines 0 comments Download
M chrome/browser/sync/glue/theme_util_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/themes/theme_service_factory.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/themes/theme_service_factory.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller.mm View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/options/options_util.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 6 chunks +8 lines, -9 lines 0 comments Download
MM chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/testing_profile.h View 4 chunks +5 lines, -0 lines 0 comments Download
M chrome/test/testing_profile.cc View 5 chunks +14 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Sigurður Ásgeirsson
9 years, 8 months ago (2011-04-12 19:05:21 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698