Issue 6813099: Add the native control panel for flash 10.3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6813099: Add the native control panel for flash 10.3 (Closed)

Created:
9 years, 8 months ago by cpu_(ooo_6.6-7.5)

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add the native control panel for flash 10.3 BUG=74035 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81786

Patch Set 1 #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+553 lines, -545 lines)			Patch
M	chrome/installer/mini_installer/chrome.release	View	1 chunk	+56 lines, -55 lines	0 comments	Download
M	chrome/tools/build/win/FILES	View	1 chunk	+70 lines, -69 lines	0 comments	Download
M	chrome/tools/build/win/FILES.cfg	View	1 chunk	+371 lines, -366 lines	0 comments	Download
M	third_party/adobe/flash/flash_player.gyp	View	1 chunk	+56 lines, -55 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

9 years, 8 months ago (2011-04-14 00:36:43 UTC) #2

LGTM, I guess. I was going to verify the name of the file, but I forgot ... so
I'll leave it to you to double-check.

http://codereview.chromium.org/6813099/diff/1/third_party/adobe/flash/flash_p...
File third_party/adobe/flash/flash_player.gyp (right):

http://codereview.chromium.org/6813099/diff/1/third_party/adobe/flash/flash_p...
third_party/adobe/flash/flash_player.gyp:38:
'binaries/win/FlashPlayerCPLApp.cpl',
Nit: You should probably list the files in the same order as you list them
elsewhere (so this should be after plugin.vch).

Expand Messages | Collapse Messages