Make the virtual driver self registering.

Make the virtual driver self registering.


BUG=
TEST=Copy the DLL to c:\windows\system32 and attempt to register and
unregister.  Both should succeed.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81505

[sanjeevr, 2011-04-13 16:21:21]

http://codereview.chromium.org/6813079/diff/1/cloud_print/virtual_driver/win/...
File cloud_print/virtual_driver/win/port_monitor/port_monitor.cc (right):

http://codereview.chromium.org/6813079/diff/1/cloud_print/virtual_driver/win/...
cloud_print/virtual_driver/win/port_monitor/port_monitor.cc:644: return
E_UNEXPECTED;
return AtlHResultFromLastError (or its equivalent) here.

http://codereview.chromium.org/6813079/diff/1/cloud_print/virtual_driver/win/...
cloud_print/virtual_driver/win/port_monitor/port_monitor.cc:656: return
E_UNEXPECTED;
Same comment as above.

[Albert Bodenhamer, 2011-04-13 18:30:38]

http://codereview.chromium.org/6813079/diff/1/cloud_print/virtual_driver/win/...
File cloud_print/virtual_driver/win/port_monitor/port_monitor.cc (right):

http://codereview.chromium.org/6813079/diff/1/cloud_print/virtual_driver/win/...
cloud_print/virtual_driver/win/port_monitor/port_monitor.cc:644: return
E_UNEXPECTED;
On 2011/04/13 16:21:21, sanjeevr wrote:
> return AtlHResultFromLastError (or its equivalent) here.

Changed to "return HRESULT_FROM_WIN32(GetLastError());" but my attempts to
upload a new patch are hanging.

http://codereview.chromium.org/6813079/diff/1/cloud_print/virtual_driver/win/...
cloud_print/virtual_driver/win/port_monitor/port_monitor.cc:656: return
E_UNEXPECTED;
On 2011/04/13 16:21:21, sanjeevr wrote:
> Same comment as above.

Ditto.

[Albert Bodenhamer, 2011-04-13 21:33:44]

There isn't a consensus on how to get the last windows error and return an
HRESULT.  I see many variants of HRESULT_FROM_WIN32(GetLastError()); as well as
AtlHResultFromLastError used frequently.

I've switched to using AtlHResultFromLastError.


On 2011/04/13 18:30:38, Albert Bodenhamer wrote:
>
http://codereview.chromium.org/6813079/diff/1/cloud_print/virtual_driver/win/...
> File cloud_print/virtual_driver/win/port_monitor/port_monitor.cc (right):
> 
>
http://codereview.chromium.org/6813079/diff/1/cloud_print/virtual_driver/win/...
> cloud_print/virtual_driver/win/port_monitor/port_monitor.cc:644: return
> E_UNEXPECTED;
> On 2011/04/13 16:21:21, sanjeevr wrote:
> > return AtlHResultFromLastError (or its equivalent) here.
> 
> Changed to "return HRESULT_FROM_WIN32(GetLastError());" but my attempts to
> upload a new patch are hanging.
> 
>
http://codereview.chromium.org/6813079/diff/1/cloud_print/virtual_driver/win/...
> cloud_print/virtual_driver/win/port_monitor/port_monitor.cc:656: return
> E_UNEXPECTED;
> On 2011/04/13 16:21:21, sanjeevr wrote:
> > Same comment as above.
> 
> Ditto.

[sanjeevr, 2011-04-13 23:30:10]

LGTM