Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 6813047: Add a script to arbitrarily change channels on image (Closed)

Created:
9 years, 8 months ago by gauravsh
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Add a script to arbitrarily change channels on image Change-Id: Icf9abbff05f9b29664216079b5c008cb7906a4f6 BUG=chrome-os-partner:3229 TEST=manually on an image. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6e567a1

Patch Set 1 #

Total comments: 4

Patch Set 2 : do not require original channel #

Patch Set 3 : usage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
A scripts/image_signing/set_channel.sh View 1 2 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gauravsh
9 years, 8 months ago (2011-04-08 17:56:06 UTC) #1
Raja Aluri
LGTM
9 years, 8 months ago (2011-04-08 18:09:42 UTC) #2
scottz-goog
http://codereview.chromium.org/6813047/diff/1/scripts/image_signing/set_channel.sh File scripts/image_signing/set_channel.sh (right): http://codereview.chromium.org/6813047/diff/1/scripts/image_signing/set_channel.sh#newcode16 scripts/image_signing/set_channel.sh:16: Usage: $PROG <image.bin> <from_channel> <to_channel> Why do we need ...
9 years, 8 months ago (2011-04-08 19:18:12 UTC) #3
gauravsh
http://codereview.chromium.org/6813047/diff/1/scripts/image_signing/set_channel.sh File scripts/image_signing/set_channel.sh (right): http://codereview.chromium.org/6813047/diff/1/scripts/image_signing/set_channel.sh#newcode16 scripts/image_signing/set_channel.sh:16: Usage: $PROG <image.bin> <from_channel> <to_channel> On 2011/04/08 19:18:12, scottz-goog ...
9 years, 8 months ago (2011-04-08 19:24:51 UTC) #4
scottz-goog
As per our discussion. Source the /etc/lsb-release file then do a sed -i 's/$CHROMEOS_RELEASE_TRACK/$new_channel/' that ...
9 years, 8 months ago (2011-04-08 19:54:56 UTC) #5
gauravsh
So sourcing /etc/lsb-release doesn't work. The CHROMEOS_RELEASE_DESCRIPTION line is syntactically incorrect (because of the parenthesis). ...
9 years, 8 months ago (2011-04-08 21:27:57 UTC) #6
scottz-goog
9 years, 8 months ago (2011-04-08 21:40:10 UTC) #7
Hah well i'll take the grep solution then :) 

LGTM

Powered by Google App Engine
This is Rietveld 408576698