Add relative path support.

pending_manager.py

 # coding=utf8
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Commit queue manager class.
 
 Security implications:
 
 The following hypothesis are made:
 - Commit queue:
@@ skipping 11 matching lines @@
 
 import find_depot_tools  # pylint: disable=W0611
 import breakpad
 import patch
 
 import checkout
 import model
 from verification import base
 
 
-def TODO(string):
-  logging.warning(string)
-
-
 def send_stack(e):
   breakpad.SendStack(e,
       ''.join(traceback.format_tb(sys.exc_info()[2])),
       maxlen=2000)
 
 
 class PendingCommit(base.Verified):
   """Represents a pending commit that is being processed."""
   persistent = base.Verified.persistent + [
       # Important since they tell if we need to revalidate and send try jobs
       # again or not if any of these value changes.
       'issue', 'patchset', 'rietveld_server', 'description',
       'files',
       # Only a cache, these values can be regenerated.
-      'owner', 'reviewers', 'base_url', 'messages',
+      'owner', 'reviewers', 'base_url', 'messages', 'relpath',
       # Only used after a patch was committed. Keeping here for completeness.
       'revision',
   ]
 
   def __init__(self, issue, owner, reviewers, patchset, base_url, description,
       messages, rietveld_server):
     super(PendingCommit, self).__init__()
     self.issue = issue
     self.owner = owner
     self.reviewers = reviewers
     self.patchset = patchset
     self.base_url = base_url
     self.rietveld_server = rietveld_server
     self.description = description
     self.messages = messages
     self.revision = None
+    self.relpath = ''
     self.files = []
 
   def patch_url(self):
     return ('%s/download/issue%d_%d.diff' %
         (self.rietveld_server,  self.issue, self.patchset))
 
   def pending_name(self):
     """The name that should be used for try jobs.
 
     It makes it possible to regenerate the try_jobs array if ever needed."""
@@ skipping 198 matching lines @@
     except ValueError:
       pass
 
   def _apply_patch(self, pending, revision):
     """Applies the pending patch to the checkout and throws if it fails.
 
     This function assumes self.checkout.prepare() was called right before.
     """
     try:
       patches = self.rietveld.get_patch(pending.issue, pending.patchset)
+      if not patches:
+        raise base.DiscardPending(
+            pending, 'No diff was found for this patchset.')
+      if pending.relpath:
+        patches.set_relpath(pending.relpath)
       pending.files = [p.filename for p in patches]
       if not pending.files:
-        raise base.DiscardPending(pending, 'No diff found.')
+        raise base.DiscardPending(
+            pending, 'No file was found in this patchset.')
       self.checkout.apply_patch(patches)
     except checkout.PatchApplicationFailed, e:
       out = 'Can\'t apply patch for file %s.' % e.filename
       if e.status:
         out += '\n%s' % e.status
       raise base.DiscardPending(pending, out)
     except patch.UnsupportedPatchFormat, e:
       raise base.DiscardPending(pending, str(e))
     except subprocess.CalledProcessError, e:
       stdout = getattr(e, 'stdout', '')
@@ skipping 33 matching lines @@
       raise base.DiscardPending(pending, out)
 
   def load(self, filename):
     """Loads the commit queue state from a JSON file."""
     self.queue = model.load_from_json_file(filename)
     self.queue.pending_commits = self.queue.pending_commits or []
 
   def save(self, filename):
     """Save the commit queue state in a simple JSON file."""
     model.save_to_json_file(filename, self.queue)