X64: Convert HeapNumbers that contain valid smi values to smis in binop-stub.

src/v8globals.h

-// Copyright 2010 the V8 project authors. All rights reserved.
+// Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
 //     * Neither the name of Google Inc. nor the names of its
 //       contributors may be used to endorse or promote products derived
 //       from this software without specific prior written permission.
 //
 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #ifndef V8_V8GLOBALS_H_
 #define V8_V8GLOBALS_H_
 
+#include <string.h>
 #include "globals.h"
 
 namespace v8 {
 namespace internal {
 
 // This file contains constants and global declarations related to the
 // V8 system.
 
 // Mask for the sign bit in a smi.
 const intptr_t kSmiSignMask = kIntptrSignBit;
@@ skipping 297 matching lines @@
 
 // Whether to remove map transitions and constant transitions from a
 // DescriptorArray.
 enum TransitionFlag {
   REMOVE_TRANSITIONS,
   KEEP_TRANSITIONS
 };
 
 
 // Union used for fast testing of specific double values.
-union DoubleRepresentation {
-  double  value;
+struct DoubleRepresentation {
+  explicit DoubleRepresentation(double x) { memcpy(&bits, &x, sizeof(bits)); }

[William Hesse, 2011/04/08 09:27:58]

Leave as is, or use BitCast - we don't want yet a third way of doing this.

[Lasse Reichstein, 2011/04/08 11:18:10]

agree. Removed.

   int64_t bits;
-  DoubleRepresentation(double x) { value = x; }
 };
 
 
 // Union used for customized checking of the IEEE double types
 // inlined within v8 runtime, rather than going to the underlying
 // platform headers and libraries
 union IeeeDoubleLittleEndianArchType {
   double d;
   struct {
     unsigned int man_low  :32;
@@ skipping 115 matching lines @@
   kStrictMode,
   // This value is never used, but is needed to prevent GCC 4.5 from failing
   // to compile when we assert that a flag is either kNonStrictMode or
   // kStrictMode.
   kInvalidStrictFlag
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_V8GLOBALS_H_