Issue 6812041: Refactor monitor_reconfigure to stop using system("xrandr").

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6812041: Refactor monitor_reconfigure to stop using system("xrandr"). (Closed)

Created:
9 years, 8 months ago by marcheu

Modified:
9 years, 7 months ago

Reviewers:
bleung1, Benson Leung

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org:9222/monitor_reconfig.git@0.11.257.B

Visibility:
Public.

Description

Refactor monitor_reconfigure to stop using system("xrandr"). This removes the blinking on monitor plug/unplug. This also avoids crashes we get on intel because of vsync bugs. Change-Id: I04ad539a66ba7db1786a4c5d0d4eb7638e99cdd1 BUG=None. TEST=Plug in a second screen, check that things display on the external screen. Unplug the screen, check that things come back on the internal lcd. Review URL: http://codereview.chromium.org/6732013 (cherry picked from commit 88f70bf3bb95e36b65c8a84efd015da30308ba61) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=0e7b6bb

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+219 lines, -147 lines)			Patch
M	monitor_reconfigure_main.h	View	1 chunk	+27 lines, -14 lines	0 comments	Download
M	monitor_reconfigure_main.cc	View	3 chunks	+99 lines, -54 lines	0 comments	Download
M	resolution_selector.h	View	4 chunks	+19 lines, -9 lines	0 comments	Download
M	resolution_selector.cc	View	5 chunks	+13 lines, -13 lines	0 comments	Download
M	resolution_selector_test.cc	View	3 chunks	+61 lines, -57 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Benson Leung

9 years, 8 months ago (2011-04-08 04:45:18 UTC) #2

On 2011/04/08 02:00:39, marcheu wrote:
> Backport from ToT

LGTM.

Expand Messages | Collapse Messages