GTK: A first *very* rough cut at a global menu.

GTK: Implement rough global menu support behind an about:flags flag.

This is a super early first cut of global menu support. It works by creating a GtkMenuBar inside chrome, attaching it to the widget hierarchy and then never showing it. This is sufficient for global menu support to detect the menu, at least on the Natty betas.

There's a lot to do before this is considered done. I haven't added Bookmark and History menus, which will need custom handling to keep state up to date with the main window. Some items may need to be moved from one menu to another to fit with Linux conventions.

Contains a bunch of new strings for global menu support. These need to go in before the M12 branch point. (I can iterate on the design afterwards; strings need translation.)

BUG=30213
TEST=Open a window on Unity. A minimal menu is in the menu bar.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81170

[Elliot Glaysher, 2011-04-08 20:55:56]

Review: estade@
FYI: evan@

[Evan Stade, 2011-04-11 19:01:35]

can you put this behind a flag until it's more fleshed out? other than that,
LGTM

http://codereview.chromium.org/6812037/diff/2006/chrome/browser/ui/gtk/browse...
File chrome/browser/ui/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/6812037/diff/2006/chrome/browser/ui/gtk/browse...
chrome/browser/ui/gtk/browser_window_gtk.cc:1547: // We hold an always hiddent
GtkMenuBar inside our browser window simply to
hidden

http://codereview.chromium.org/6812037/diff/2006/chrome/browser/ui/gtk/browse...
chrome/browser/ui/gtk/browser_window_gtk.cc:1551: global_menu_bar_.reset(new
GlobalMenuBar(browser_.get(), this));
should this be disabled for some browser windows, like popups? or would that
just affect the contents of the menus?

http://codereview.chromium.org/6812037/diff/2006/chrome/browser/ui/gtk/global...
File chrome/browser/ui/gtk/global_menu_bar.cc (right):

http://codereview.chromium.org/6812037/diff/2006/chrome/browser/ui/gtk/global...
chrome/browser/ui/gtk/global_menu_bar.cc:31: { IDS_NEW_TAB, IDC_NEW_TAB },
where are you getting these items from? Are you trying to match mac chrome, or
native gtk apps' menus, or what?

[Elliot Glaysher, 2011-04-11 23:18:52]

http://codereview.chromium.org/6812037/diff/2006/chrome/browser/ui/gtk/browse...
File chrome/browser/ui/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/6812037/diff/2006/chrome/browser/ui/gtk/browse...
chrome/browser/ui/gtk/browser_window_gtk.cc:1551: global_menu_bar_.reset(new
GlobalMenuBar(browser_.get(), this));
On 2011/04/11 19:01:35, Evan Stade wrote:
> should this be disabled for some browser windows, like popups? or would that
> just affect the contents of the menus?

Those windows would then lack menubars.

http://codereview.chromium.org/6812037/diff/2006/chrome/browser/ui/gtk/global...
File chrome/browser/ui/gtk/global_menu_bar.cc (right):

http://codereview.chromium.org/6812037/diff/2006/chrome/browser/ui/gtk/global...
chrome/browser/ui/gtk/global_menu_bar.cc:31: { IDS_NEW_TAB, IDC_NEW_TAB },
On 2011/04/11 19:01:35, Evan Stade wrote:
> where are you getting these items from? Are you trying to match mac chrome, or
> native gtk apps' menus, or what?

This is a combination of mac chrome, and linux firefox. The file menu is
verbatim mac sans a mac specific feature (emailing a page link). The edit menu
is meant to eventually emulate a native gtk edit menu. Views is copied from mac,
but needs restructuring to feel like a linux menu. Tools is a mix of the firefox
linux tools menu and our tools menu.

Bookmark/History (which aren't implemented here because that will take some more
work) will follow both; mac chrome and linux firefox are comporable.

[Evan Stade, 2011-04-11 23:41:34]

http://codereview.chromium.org/6812037/diff/2006/chrome/browser/ui/gtk/browse...
File chrome/browser/ui/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/6812037/diff/2006/chrome/browser/ui/gtk/browse...
chrome/browser/ui/gtk/browser_window_gtk.cc:1551: global_menu_bar_.reset(new
GlobalMenuBar(browser_.get(), this));
On 2011/04/11 23:18:52, Elliot Glaysher wrote:
> On 2011/04/11 19:01:35, Evan Stade wrote:
> > should this be disabled for some browser windows, like popups? or would that
> > just affect the contents of the menus?
> 
> Those windows would then lack menubars.

well, we don't show the wrench menu for popup windows, although why I'm not sure

[dbarth4, 2011-04-12 17:17:34]

It's great to see the first stages of that integration. Let us know if you need
any help or clarifications from the Canonical DX Team in the process.

[Evan Martin, 2011-04-14 15:43:56]

Rad.

On Tue, Apr 12, 2011 at 10:17 AM,  <dbarth4@gmail.com> wrote:
> It's great to see the first stages of that integration. Let us know if you
> need
> any help or clarifications from the Canonical DX Team in the process.
>
> http://codereview.chromium.org/6812037/
>