Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 6812021: Rely on Portage to run required stages before "test" stage. (Closed)

Created:
9 years, 8 months ago by mtennant
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Rely on Portage to run required stages before "test" stage. Previously, the cros unit test function was telling Portage exactly which flow stages to run leading up to the "test" stage by giving the "noauto" FEATURE and specifying each stage explicitly. This proved unnecessarily brittle, so now we rely on Portage's default behavior to determine which stages must be run before the requested "test" stage. Also added explicit "clean" stage after test to remove all temporary files from disk. Change-Id: I7e0a9e0ecc29eee2b564e78f9078a8da43b96167 BUG=chromium-os:13634 TEST=./cros_run_unit_tests --board=x86-mario --packages=chromeos-wm Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=be2351f

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding period at end of comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M cros_run_unit_tests View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtennant
Please review.
9 years, 8 months ago (2011-04-07 17:00:46 UTC) #1
davidjames
LGTM w/nit http://codereview.chromium.org/6812021/diff/1/cros_run_unit_tests File cros_run_unit_tests (right): http://codereview.chromium.org/6812021/diff/1/cros_run_unit_tests#newcode50 cros_run_unit_tests:50: # Run the unit test for the ...
9 years, 8 months ago (2011-04-07 17:02:07 UTC) #2
Daniel Erat
LGTM. Thanks!
9 years, 8 months ago (2011-04-07 17:08:03 UTC) #3
sosa
LGTM here a well. Can you just re-verify that all packages run? Run without --package ...
9 years, 8 months ago (2011-04-07 17:08:42 UTC) #4
mtennant
I just completed a full sync and run of all package unit tests, which passed. ...
9 years, 8 months ago (2011-04-07 18:46:20 UTC) #5
sosa
SGTM. Thanks for the extra testing! On Thu, Apr 7, 2011 at 11:46 AM, <mtennant@chromium.org> ...
9 years, 8 months ago (2011-04-07 19:48:53 UTC) #6
mtennant
9 years, 8 months ago (2011-04-07 20:01:43 UTC) #7
Feedback addressed.  Pushing shortly.

http://codereview.chromium.org/6812021/diff/1/cros_run_unit_tests
File cros_run_unit_tests (right):

http://codereview.chromium.org/6812021/diff/1/cros_run_unit_tests#newcode50
cros_run_unit_tests:50: # Run the unit test for the given package, via ebuild
src_test() function
On 2011/04/07 17:02:07, davidjames wrote:
> Could you add a trailing period?

Done.

Powered by Google App Engine
This is Rietveld 408576698