Issue 6812016: Clarify documentation about when a task may fail to post to a message loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6812016: Clarify documentation about when a task may fail to post to a message loop (Closed)

Created:
9 years, 8 months ago by joth

Modified:
9 years, 7 months ago

Reviewers:
sanjeevr, willchan no longer on Chromium

CC:
chromium-reviews, Bernhard Bauer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Clarify documentation about when a task may fail to post to a message loop BUG=None TEST=still builds... Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80794

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	base/message_loop_proxy.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

joth

Follow up to chromium-dev discussion: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/d39f837234cde521#

9 years, 8 months ago (2011-04-07 13:55:32 UTC) #1

joth

Thanks! Committed. I'll take a stab at https://sites.google.com/a/chromium.org/dev/developers/design-documents/threading/suble-threading-bugs-and-patterns-to-avoid-them?pli=1 too. Currently it doesn't mention MessageLoopProxy at ...

9 years, 8 months ago (2011-04-07 16:42:47 UTC) #4

joth

9 years, 8 months ago (2011-04-07 16:57:06 UTC) #5

On 7 April 2011 17:42, Jonathan Dixon <joth@chromium.org> wrote:

> Thanks! Committed.
>
> I'll take a stab at
>
https://sites.google.com/a/chromium.org/dev/developers/design-documents/threa...
too.
> Currently it doesn't mention MessageLoopProxy at all.
>
> Done. If you have a moment please glance over
https://sites.google.com/a/chromium.org/dev/system/app/pages/admin/compare?wu...
(and
feel free to make corrections or further improvements right in there)

Cheers!

Expand Messages | Collapse Messages