Issue 6812006: Enable -Wall -Werror and fix 2 compile-errors it would introduce.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6812006: Enable -Wall -Werror and fix 2 compile-errors it would introduce. (Closed)

Created:
9 years, 8 months ago by jimhebert

Modified:
9 years, 7 months ago

Reviewers:
Chaitanya, davejcool

CC:
chromium-os-reviews_chromium.org, Will Drewry, Sumit

Base URL:
ssh://git@gitrw.chromium.org:9222/speech_synthesis.git@master

Visibility:
Public.

Description

Enable -Wall -Werror and fix 2 compile-errors it would introduce. Change-Id: I9150969787f308152d49c82d31078df50deabdcd BUG=chromium-os:13800 TEST=emerge-x86-mario speech_synthesis and emerge-arm-generic speech_synthesis both compile cleanly Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bd70d1a

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -1 line)			Patch
M	Makefile	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	earcon_manager.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	speech_synthesizer_service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jimhebert

Friendly ping and also adding davej as a possible Reviewer since it looks like he ...

9 years, 8 months ago (2011-04-11 23:41:11 UTC) #2

Chaitanya

lgtm do x86-pineview and x86-generic compile fine? thanks for the cleanup! On 2011/04/11 23:41:11, jimhebert ...

9 years, 8 months ago (2011-04-12 07:11:35 UTC) #3

jimhebert

9 years, 8 months ago (2011-04-12 17:02:04 UTC) #4

On 2011/04/12 07:11:35, Chaitanya wrote:
> lgtm
> do x86-pineview and x86-generic compile fine?
Yes, just re-checked on both those. Thanks!

> thanks for the cleanup!
> 
> On 2011/04/11 23:41:11, jimhebert wrote:
> > Friendly ping and also adding davej as a possible Reviewer since it looks
like
> > he has recent work on the code. I'm just trying to git some trivial cleanup
> > changes approved. :) Thanks in advance!

Expand Messages | Collapse Messages