sync: Make nudge + config jobs reliable in SyncerThread2

chrome/browser/sync/glue/sync_backend_host.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
@@ skipping 394 matching lines @@
   {
     base::AutoLock lock(registrar_lock_);
     pending_config_mode_state_.reset(
         MakePendingConfigModeState(data_type_controllers, types, ready_task,
                                    &registrar_.routing_info));
   }
 
   // If we're doing the first configure (at startup) this is redundant as the
   // syncer thread always must start in config mode.
   if (using_new_syncer_thread_) {
-    core_->syncapi()->StartConfigurationMode(NewCallback(core_.get(),
-        &SyncBackendHost::Core::FinishConfigureDataTypes));
+    core_thread_.message_loop()->PostTask(
+        FROM_HERE,
+        NewRunnableMethod(core_.get(),
+        &SyncBackendHost::Core::StartConfigurationMode));
   } else {
     FinishConfigureDataTypesOnFrontendLoop();
   }
 }
 
 void SyncBackendHost::FinishConfigureDataTypesOnFrontendLoop() {
   DCHECK_EQ(MessageLoop::current(), frontend_loop_);
   // Nudge the syncer. This is necessary for both datatype addition/deletion.
   //
   // Deletions need a nudge in order to ensure the deletion occurs in a timely
@@ skipping 219 matching lines @@
 
 void SyncBackendHost::Core::CreateSyncNotifier(
     const scoped_refptr<net::URLRequestContextGetter>& request_context_getter) {
   const std::string& client_info = webkit_glue::GetUserAgent(GURL());
   SyncNotifierFactory sync_notifier_factory(client_info);
   sync_notifier_.reset(sync_notifier_factory.CreateSyncNotifier(
       *CommandLine::ForCurrentProcess(),
       request_context_getter));
 }
 
+void SyncBackendHost::Core::StartConfigurationMode() {

[tim (not reviewing), 2011/04/15 00:21:43]

should call this 'DoStartConfigurationMode'

[lipalani1, 2011/04/15 01:24:39]

Done.

+  syncapi_->StartConfigurationMode(NewCallback(this,
+        &SyncBackendHost::Core::FinishConfigureDataTypes));
+}
+
 SyncBackendHost::Core::DoInitializeOptions::DoInitializeOptions(
     const GURL& service_url,
     sync_api::HttpPostProviderFactory* http_bridge_factory,
     const sync_api::SyncCredentials& credentials,
     bool delete_sync_data_folder,
     const std::string& restored_key_for_bootstrapping,
     bool setup_for_test_mode)
     : service_url(service_url),
       http_bridge_factory(http_bridge_factory),
       credentials(credentials),
@@ skipping 544 matching lines @@
   DCHECK_EQ(MessageLoop::current(), host_->core_thread_.message_loop());
   syncapi_->GetJsBackend()->ProcessMessage(name, args, sender);
 }
 
 void SyncBackendHost::Core::DeferNudgeForCleanup() {
   DCHECK_EQ(MessageLoop::current(), host_->core_thread_.message_loop());
   deferred_nudge_for_cleanup_requested_ = true;
 }
 
 }  // namespace browser_sync