Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 6812002: Add GCMole to the repository. (Closed)

Created:
9 years, 8 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add GCMole to the repository. GCMole is a simple static analysis tool that searches for GC-usafe evaluation order dependent callsites. Committed: http://code.google.com/p/v8/source/detail?r=7540

Patch Set 1 #

Total comments: 5

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+875 lines, -0 lines) Patch
A tools/gcmole/Makefile View 1 1 chunk +43 lines, -0 lines 0 comments Download
A tools/gcmole/README View 1 1 chunk +62 lines, -0 lines 0 comments Download
A tools/gcmole/gcmole.cc View 1 1 chunk +495 lines, -0 lines 0 comments Download
A tools/gcmole/gcmole.lua View 1 1 chunk +275 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
9 years, 8 months ago (2011-04-06 23:48:49 UTC) #1
Søren Thygesen Gjesse
9 years, 8 months ago (2011-04-07 08:20:28 UTC) #2
LGTM

http://codereview.chromium.org/6812002/diff/1/tools/gcmole/Makefile
File tools/gcmole/Makefile (right):

http://codereview.chromium.org/6812002/diff/1/tools/gcmole/Makefile#newcode34
tools/gcmole/Makefile:34: g++ -I$(LLVM_INCLUDE) -I$(CLANG_INCLUDE) -I. -D_DEBUG
-D_GNU_SOURCE -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -O3
-fomit-frame-pointer -fno-exceptions -fno-rtti -fPIC -Woverloaded-virtual
-Wcast-qual -fno-strict-aliasing -pedantic -Wno-long-long -Wall -W
-Wno-unused-parameter -Wwrite-strings -shared -o libgcmole.so gcmole.cc
Break up this long line?

http://codereview.chromium.org/6812002/diff/1/tools/gcmole/README
File tools/gcmole/README (right):

http://codereview.chromium.org/6812002/diff/1/tools/gcmole/README#newcode8
tools/gcmole/README:8: Handle<Object> Foo();  // assume Foo can trigger a GC.
Start comment with uppercase - even in README :-)

http://codereview.chromium.org/6812002/diff/1/tools/gcmole/README#newcode20
tools/gcmole/README:20: PREREQUISITES
-------------------------------------------------------------------
Long line (few more below).

http://codereview.chromium.org/6812002/diff/1/tools/gcmole/gcmole.cc
File tools/gcmole/gcmole.cc (right):

http://codereview.chromium.org/6812002/diff/1/tools/gcmole/gcmole.cc#newcode213
tools/gcmole/gcmole.cc:213: if (decl->getTemplatedDecl()->getDeclName() ==
handleDeclName) return true;
Long line.

http://codereview.chromium.org/6812002/diff/1/tools/gcmole/gcmole.lua
File tools/gcmole/gcmole.lua (right):

http://codereview.chromium.org/6812002/diff/1/tools/gcmole/gcmole.lua#newcode1
tools/gcmole/gcmole.lua:1: -- Copyright 2011 the V8 project authors. All rights
reserved.
I don't have the Lua stule quide at hand but it would probably say no long lines
(and that you should use Python :-) ).

Powered by Google App Engine
This is Rietveld 408576698