Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Unified Diff: chrome/browser/chromeos/status/network_menu.h

Issue 6811025: Change status button menu implementation from Menu2 to MenuItemView. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Changed refcount guard to use OS_CHROMEOS. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/status/network_menu.h
diff --git a/chrome/browser/chromeos/status/network_menu.h b/chrome/browser/chromeos/status/network_menu.h
index f96d49f15bee0db9f3c7042528073462a0a49ab4..f1eeadc5950bed35763c3563036bd7caefcf5f88 100644
--- a/chrome/browser/chromeos/status/network_menu.h
+++ b/chrome/browser/chromeos/status/network_menu.h
@@ -11,18 +11,16 @@
#include "chrome/browser/chromeos/options/network_config_view.h"
#include "third_party/skia/include/core/SkBitmap.h"
-#include "ui/base/models/simple_menu_model.h"
+#include "ui/base/models/menu_model.h"
#include "ui/gfx/native_widget_types.h"
+#include "views/controls/button/menu_button.h"
+#include "views/controls/menu/menu_delegate.h"
#include "views/controls/menu/view_menu_delegate.h"
namespace gfx {
class Canvas;
}
-namespace views {
-class Menu2;
-}
-
namespace chromeos {
// Menu for network menu button in the status area/welcome screen.
@@ -48,8 +46,8 @@ namespace chromeos {
//
// <icon> will show the strength of the wifi/cellular networks.
// The label will be BOLD if the network is currently connected.
-class NetworkMenu : public views::ViewMenuDelegate,
- public ui::MenuModel {
+class NetworkMenu : public views::MenuDelegate,
+ public views::ViewMenuDelegate {
public:
struct NetworkInfo {
NetworkInfo() :
@@ -87,28 +85,12 @@ class NetworkMenu : public views::ViewMenuDelegate,
const std::string& ssid,
int remember) const;
- // ui::MenuModel implementation.
- virtual bool HasIcons() const { return true; }
- virtual int GetItemCount() const;
- virtual ui::MenuModel::ItemType GetTypeAt(int index) const;
- virtual int GetCommandIdAt(int index) const { return index; }
- virtual string16 GetLabelAt(int index) const;
- virtual bool IsItemDynamicAt(int index) const { return true; }
- virtual const gfx::Font* GetLabelFontAt(int index) const;
- virtual bool GetAcceleratorAt(int index,
- ui::Accelerator* accelerator) const { return false; }
- virtual bool IsItemCheckedAt(int index) const;
- virtual int GetGroupIdAt(int index) const { return 0; }
- virtual bool GetIconAt(int index, SkBitmap* icon);
- virtual ui::ButtonMenuItemModel* GetButtonMenuItemAt(int index) const {
- return NULL;
- }
- virtual bool IsEnabledAt(int index) const;
- virtual ui::MenuModel* GetSubmenuModelAt(int index) const { return NULL; }
- virtual void HighlightChangedTo(int index) {}
- virtual void ActivatedAt(int index);
- virtual void MenuWillShow() {}
- virtual void SetMenuModelDelegate(ui::MenuModelDelegate* delegate) {}
+ // views::MenuDelegate implementation
+ virtual std::wstring GetLabel(int id) const;
oshima 2011/04/14 17:27:31 OVERRIDE
rhashimoto 2011/04/14 18:27:04 Done.
+ virtual const gfx::Font* GetLabelFont(int id) const;
+ virtual bool IsItemChecked(int id) const;
+ virtual bool IsCommandEnabled(int id) const;
+ virtual void ExecuteCommand(int id);
void SetFirstLevelMenuWidth(int width);
@@ -161,6 +143,7 @@ class NetworkMenu : public views::ViewMenuDelegate,
protected:
virtual bool IsBrowserMode() const = 0;
+ virtual views::MenuButton* GetMenuButton() = 0;
virtual gfx::NativeWindow GetNativeWindow() const = 0;
virtual void OpenButtonOptions() = 0;
virtual bool ShouldOpenButtonOptions() const = 0;
@@ -245,7 +228,7 @@ class NetworkMenu : public views::ViewMenuDelegate,
MenuItemVector menu_items_;
// The network menu.
- scoped_ptr<views::Menu2> network_menu_;
+ scoped_ptr<views::MenuItemView> network_menu_;
// Holds minimum width or -1 if it wasn't set up.
int min_width_;

Powered by Google App Engine
This is Rietveld 408576698