Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: webkit/fileapi/sandbox_mount_point_provider.cc

Issue 6810037: File API changes needed for safely passing user selected file entities from the file browser comp... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/sandbox_mount_point_provider.cc
===================================================================
--- webkit/fileapi/sandbox_mount_point_provider.cc (revision 80841)
+++ webkit/fileapi/sandbox_mount_point_provider.cc (working copy)
@@ -126,11 +126,17 @@
SandboxMountPointProvider::~SandboxMountPointProvider() {
}
-bool SandboxMountPointProvider::IsAccessAllowed(const GURL& origin_url) {
+bool SandboxMountPointProvider::IsAccessAllowed(const GURL& origin_url,
+ const FilePath& unused) {
// We essentially depend on quota to do our access controls.
return path_manager_->IsAllowedScheme(origin_url);
}
+void SandboxMountPointProvider::GrantAccess(const GURL& origin_url,
+ const FilePath& virtual_path) {
+ NOTREACHED();
+}
+
class SandboxMountPointProvider::GetFileSystemRootPathTask
: public base::RefCountedThreadSafe<
SandboxMountPointProvider::GetFileSystemRootPathTask> {
@@ -211,6 +217,14 @@
return false;
}
+std::vector<FilePath> SandboxMountPointProvider::GetRootDirectories() const {
+ NOTREACHED();
+ // TODO(ericu): Implement this method and check for access permissions as
+ // fileBrowserPrivate extension API does. We currently have another mechanism,
+ // but we should switch over.
+ return std::vector<FilePath>();
+}
+
void SandboxMountPointProvider::GetFileSystemRootPath(
const GURL& origin_url, fileapi::FileSystemType type,
bool create, FileSystemPathManager::GetRootPathCallback* callback_ptr) {

Powered by Google App Engine
This is Rietveld 408576698