File API changes needed for safely passing user selected file entities from the file browser comp...

webkit/fileapi/file_system_path_manager.h

Index: webkit/fileapi/file_system_path_manager.h
===================================================================
--- webkit/fileapi/file_system_path_manager.h	(revision 81576)
+++ webkit/fileapi/file_system_path_manager.h	(working copy)
@@ -20,7 +20,7 @@
 
 namespace fileapi {
 
-class FileSystemMountPointProvider;
+class ExternalFileSystemMountPointProvider;
 class SandboxMountPointProvider;
 
 // TODO(kinuko): Probably this module must be called FileSystemPathUtil
@@ -81,13 +81,19 @@
   bool IsRestrictedFileName(FileSystemType type,
                             const FilePath& filename);
 
-  // Checks if an origin has access to a particular filesystem type.
-  bool IsAllowedFileSystemType(GURL origin, FileSystemType type);
+  // Checks if an origin has access to a particular filesystem type and
+  // file element represented by |virtual_path|.
+  bool IsAllowedFileSystemType(const GURL& origin, FileSystemType type,

[ericu, 2011/04/15 01:46:42]

This is no longer really about the type.  How about changing the name to
IsAccessAllowed?

SandboxMPP just turns around and calls IsAllowedScheme, and will probably just
keep doing that.  We should just move IsAllowedScheme to SandboxMPP [inlined in
the body of the impl of this method], BTW, but that can wait until a later CL.

[zel, 2011/04/15 02:18:55]

Rename done.

+                               const FilePath& virtual_path);
 
   SandboxMountPointProvider* sandbox_provider() const {
     return sandbox_provider_.get();
   }
 
+  ExternalFileSystemMountPointProvider* external_provider() const {
+    return external_provider_.get();
+  }
+
   bool is_incognito() const {
     return is_incognito_;
   }
@@ -96,7 +102,7 @@
   const bool is_incognito_;
   const bool allow_file_access_from_files_;
   scoped_ptr<SandboxMountPointProvider> sandbox_provider_;
-  scoped_ptr<FileSystemMountPointProvider> local_provider_;
+  scoped_ptr<ExternalFileSystemMountPointProvider> external_provider_;
 
   DISALLOW_COPY_AND_ASSIGN(FileSystemPathManager);
 };