File API changes needed for safely passing user selected file entities from the file browser comp...

webkit/fileapi/sandbox_mount_point_provider.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_SANDBOX_MOUNT_POINT_PROVIDER_H_
 #define WEBKIT_FILEAPI_SANDBOX_MOUNT_POINT_PROVIDER_H_
 
 #include <string>
+#include <vector>
 
 #include "base/file_path.h"
 #include "googleurl/src/gurl.h"
 #include "webkit/fileapi/file_system_mount_point_provider.h"
 
 class GURL;
 
 namespace base {
 class MessageLoopProxy;
 }
 
 namespace fileapi {
 
 class SandboxMountPointProvider : public FileSystemMountPointProvider {
  public:
 
   SandboxMountPointProvider(
       FileSystemPathManager* path_manager,
       scoped_refptr<base::MessageLoopProxy> file_message_loop,
       const FilePath& profile_path);
   virtual ~SandboxMountPointProvider();
 
-  // Checks if mount point access is allowed from |origin_url|.
-  virtual bool IsAccessAllowed(const GURL& origin_url);
+  // Checks if access to |virtual_path| is allowed from |origin_url|.
+  virtual bool IsAccessAllowed(const GURL& origin_url,
+                               const FilePath& virtual_path);
+  virtual void GrantAccess(const GURL& origin_url,
+                           const FilePath& virtual_path);

[michaeln, 2011/04/09 00:16:45]

is there a use case for revoking access?

[zel, 2011/04/13 00:44:26]

Not right now. All extension permissions are revoked when extension is unloaded
and that is already handled by ExtensionSpecialStoragePolicy.

 
   // Retrieves the root path for the given |origin_url| and |type|, and
   // calls the given |callback| with the root path and name.
   // If |create| is true this also creates the directory if it doesn't exist.
   virtual void GetFileSystemRootPath(
       const GURL& origin_url,
       FileSystemType type,
       bool create,
       FileSystemPathManager::GetRootPathCallback* callback);
 
@@ skipping 11 matching lines @@
   static const char kPersistentName[];
   static const char kTemporaryName[];
 
   const FilePath& base_path() const {
     return base_path_;
   }
 
   // Checks if a given |name| contains any restricted names/chars in it.
   virtual bool IsRestrictedFileName(const FilePath& filename) const;
 
+  virtual std::vector<FilePath> GetRootDirectories() const;
+
   // Returns the origin identifier string, which is used as a part of the
   // sandboxed path component, for the given |url|.
   static std::string GetOriginIdentifierFromURL(const GURL& url);
 
   // Gets a base directory path of the sandboxed filesystem that is
   // specified by |origin_identifier| and |type|.
   // |base_path| must be pointing the FileSystem's data directory
   // under the profile directory, i.e. <profile_dir>/kFileSystemDirectory.
   // Returns an empty path if any of the given parameters are invalid.
   // Returned directory path does not contain 'unique' part, therefore
@@ skipping 39 matching lines @@
 
   const FilePath base_path_;
 
   DISALLOW_COPY_AND_ASSIGN(SandboxMountPointProvider);
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_FILEAPI_SANDBOX_MOUNT_POINT_PROVIDER_H_