File API changes needed for safely passing user selected file entities from the file browser comp...

chrome/browser/extensions/extension_special_storage_policy.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SPECIAL_STORAGE_POLICY_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SPECIAL_STORAGE_POLICY_H_
 #pragma once
 
 #include <map>
+#include <set>

[michaeln, 2011/04/14 21:25:34]

needed?

[zel, 2011/04/14 21:46:20]

Done.

 #include <string>
 
+#include "base/file_path.h"

[michaeln, 2011/04/14 21:25:34]

needed?

[zel, 2011/04/14 21:46:20]

Done.

 #include "base/synchronization/lock.h"
 #include "googleurl/src/gurl.h"
 #include "webkit/quota/special_storage_policy.h"
 
 class Extension;
 
 // Special rights are granted to 'extensions' and 'applications'. The
 // storage subsystems and the browsing data remover query this interface
 // to determine which origins have these rights.
 class ExtensionSpecialStoragePolicy : public quota::SpecialStoragePolicy {
  public:
   ExtensionSpecialStoragePolicy();
 
   // SpecialStoragePolicy methods used by storage subsystems and the browsing
   // data remover. These methods are safe to call on any thread.
   virtual bool IsStorageProtected(const GURL& origin);
   virtual bool IsStorageUnlimited(const GURL& origin);
-  virtual bool IsLocalFileSystemAccessAllowed(const GURL& origin);
+  virtual bool IsFileHanlder(const std::string& extension_id);

[michaeln, 2011/04/14 21:25:34]

typo... IsFileHandler

[zel, 2011/04/14 21:46:20]

Done.

 
   // Methods used by the ExtensionService to populate this class.
   void GrantRightsForExtension(const Extension* extension);
   void RevokeRightsForExtension(const Extension* extension);
   void RevokeRightsForAllExtensions();
 
  private:
   class SpecialCollection {
    public:
     SpecialCollection();
-    ~SpecialCollection();
+    virtual ~SpecialCollection();

[michaeln, 2011/04/14 21:25:34]

this can be de-virtualized now

[zel, 2011/04/14 21:46:20]

Done.

 
     bool Contains(const GURL& origin);
     void Add(const Extension* extension);
     void Remove(const Extension* extension);
     void Clear();
+    bool ContainsExtension(const std::string& extension_id);

[michaeln, 2011/04/14 21:25:34]

nit: move this method declaration up under Contains(origin) and similarly keep
the methods in the .cc file in the same order as declared

[zel, 2011/04/14 21:46:20]

Done.

 
-   private:
+   protected:

[michaeln, 2011/04/14 21:25:34]

can remain private

[zel, 2011/04/14 21:46:20]

Done.

     typedef std::map<GURL, bool> CachedResults;
     typedef std::map<std::string, scoped_refptr<const Extension> > Extensions;
     Extensions extensions_;
-    CachedResults cached_resuts_;
+    CachedResults cached_results_;
   };
 
   virtual ~ExtensionSpecialStoragePolicy();
 
   base::Lock lock_;  // Synchronize all access to the collections.
   SpecialCollection protected_apps_;
   SpecialCollection unlimited_extensions_;
-  SpecialCollection local_filesystem_extensions_;
+  SpecialCollection file_handler_extensions_;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SPECIAL_STORAGE_POLICY_H_