Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 6810022: Fix kernel testing and make it target specific. (Closed)

Created:
9 years, 8 months ago by vb
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Randall Spangler
Visibility:
Public.

Description

Fix kernel testing and make it target specific. Note that this change is in R11, as it should be enabled asap. This CL fixes kernel messages autotest by introducing platform specific lists of the kernel warning and error messages expected on startup. Some of these messages are harmless, and some require investigation/fixing. This CL just cleans up the lists of accepted error/warning messages and provides for platform specific extensions. The recently introduced crossystem utility is the way to deteremine system specific parameters in a platform independent way. This CL introduces a class to represent the crossystem reported information in a programmatic way. The crossystem output of form 'name = value' is parsed and placed in a dictionary. The __getatttr__() method override allows to use object_instance.name() to access the value of the parameter 'name'. Instead of using exact warning/error messages' list the regexes of messages are allowed, which is handy in situations when messages are run time specific (use hash values or addresses, etc.) Change-Id: Ia4af19e231c9bc2665f7f6094e7c4f541f69148b BUG=chromium-os:13937 TEST=manual, see below ./run_remote_tests.sh --board x86-alex --remote 172.22.75.120 kernel_BootMessagesServer ... INFO : Test results: --------------------------------------------------------- kernel_BootMessagesServer PASS kernel_BootMessagesServer/kernel_BootMessagesServer PASS coldboot_active_mb 59 coldboot_anonpages_mb 37 coldboot_buffers_mb 3 coldboot_cached_mb 177 coldboot_inactive_mb 159 coldboot_memfree_mb 1637 --------------------------------------------------------- Total PASS: 2/2 (100%) =========================================================== ./run_remote_tests.sh --board x86-mario --remote 172.22.75.17 kernel_BootMessagesServer ... INFO : Test results: --------------------------------------------------------- kernel_BootMessagesServer PASS kernel_BootMessagesServer/kernel_BootMessagesServer PASS coldboot_active_mb 48 coldboot_anonpages_mb 35 coldboot_buffers_mb 3 coldboot_cached_mb 155 coldboot_inactive_mb 145 coldboot_memfree_mb 1662 --------------------------------------------------------- Total PASS: 2/2 (100%) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=dad4a0c

Patch Set 1 : Fix bioot messages autotest #

Total comments: 6

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -24 lines) Patch
M client/bin/site_utils.py View 1 2 chunks +39 lines, -6 lines 0 comments Download
M server/site_tests/kernel_BootMessagesServer/kernel_BootMessagesServer.py View 3 chunks +42 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vb
9 years, 8 months ago (2011-04-07 16:58:23 UTC) #1
Mandeep Singh Baines
LGTM with some minor nits. http://codereview.chromium.org/6810022/diff/2001/client/bin/site_utils.py File client/bin/site_utils.py (right): http://codereview.chromium.org/6810022/diff/2001/client/bin/site_utils.py#newcode24 client/bin/site_utils.py:24: f = open(fname, 'w') ...
9 years, 8 months ago (2011-04-07 21:15:42 UTC) #2
vb
9 years, 8 months ago (2011-04-07 21:34:59 UTC) #3
http://codereview.chromium.org/6810022/diff/2001/client/bin/site_utils.py
File client/bin/site_utils.py (right):

http://codereview.chromium.org/6810022/diff/2001/client/bin/site_utils.py#new...
client/bin/site_utils.py:24: f = open(fname, 'w')
On 2011/04/07 21:15:42, Mandeep Singh Baines wrote:
> Why not use the fd from above?

It gets messy with files opened on client/host, etc.

http://codereview.chromium.org/6810022/diff/2001/client/bin/site_utils.py#new...
client/bin/site_utils.py:27: text = open(fname).read()
On 2011/04/07 21:15:42, Mandeep Singh Baines wrote:
> Use utils.read_file() instead.

Done.

http://codereview.chromium.org/6810022/diff/2001/client/bin/site_utils.py#new...
client/bin/site_utils.py:29: assignment_string = line.strip().split('#')[0]
On 2011/04/07 21:15:42, Mandeep Singh Baines wrote:
> The strip here seems unnecessary.
true, done.

Powered by Google App Engine
This is Rietveld 408576698