Issue 6810012: Add verbose support throught presubmit checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6810012: Add verbose support throught presubmit checks (Closed)

Created:
9 years, 8 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Add verbose support throught presubmit checks Add propagation of verbose flag from git cl to presubmit_support Rename NotImplementedException to standard NotImplementError. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80798

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased against head #

Patch Set 3 : merge error #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -123 lines)			Patch
M	PRESUBMIT.py	View		2 chunks	+4 lines, -6 lines	0 comments	Download
M	git_cl.py	View		7 chunks	+21 lines, -11 lines	0 comments	Download
M	presubmit_canned_checks.py	View	1 2	5 chunks	+6 lines, -8 lines	0 comments	Download
M	presubmit_support.py	View		19 chunks	+58 lines, -45 lines	0 comments	Download
M	tests/presubmit_unittest.py	View		21 chunks	+60 lines, -53 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

LGTM. Nice change. http://codereview.chromium.org/6810012/diff/1/presubmit_support.py File presubmit_support.py (right): http://codereview.chromium.org/6810012/diff/1/presubmit_support.py#newcode1185 presubmit_support.py:1185: logging.basicConfig(level=logging.ERROR) Nit: I'd probably set things ...

9 years, 8 months ago (2011-04-07 01:46:42 UTC) #2

M-A Ruel

9 years, 8 months ago (2011-04-07 01:52:53 UTC) #3

http://codereview.chromium.org/6810012/diff/1/presubmit_support.py
File presubmit_support.py (right):

http://codereview.chromium.org/6810012/diff/1/presubmit_support.py#newcode1185
presubmit_support.py:1185: logging.basicConfig(level=logging.ERROR)
On 2011/04/07 01:46:42, Dirk Pranke wrote:
> Nit: I'd probably set things to WARNING by default, not ERROR.

All the other ones default to ERROR because WARNING logs confuse the user, it
did in the past.

Expand Messages | Collapse Messages