Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 6805027: Temporarily change bgscan threshold in MultiSwitchBack (Closed)

Created:
9 years, 8 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
Sam Leffler
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Temporarily change bgscan threshold in MultiSwitchBack This makes the test more reliable by making it more sensitive to the AP's change in signal level. Also use new method to reset background scan parameters back to default after connection is made. BUG=chromium-os:13938 TEST=Rerun test Change-Id: I9abea39ee11177ffb876a75f6d1990270fbb7f4a R=sleffler@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=46877f6

Patch Set 1 #

Total comments: 2

Patch Set 2 : Method for resetting parameters changed #

Patch Set 3 : More explicit comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M server/site_tests/network_WiFiRoaming/003SSIDMultiSwitchBack View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M server/site_wifitest.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Stewart
9 years, 8 months ago (2011-04-07 17:34:53 UTC) #1
Sam Leffler
What changed that required futzing with the threshold? http://codereview.chromium.org/6805027/diff/1/server/site_tests/network_WiFiRoaming/003SSIDMultiSwitchBack File server/site_tests/network_WiFiRoaming/003SSIDMultiSwitchBack (right): http://codereview.chromium.org/6805027/diff/1/server/site_tests/network_WiFiRoaming/003SSIDMultiSwitchBack#newcode16 server/site_tests/network_WiFiRoaming/003SSIDMultiSwitchBack:16: [ ...
9 years, 8 months ago (2011-04-07 19:08:06 UTC) #2
Paul Stewart
Made the comment more explicit. I think that the threshold has always been a little ...
9 years, 8 months ago (2011-04-07 21:16:00 UTC) #3
Sam Leffler
9 years, 8 months ago (2011-04-07 21:32:37 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698