Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 6805015: Re-adding get_site_job_data(): Now uses host platform for hostname. (Closed)

Created:
9 years, 8 months ago by pauldean_chromium
Modified:
9 years, 7 months ago
Reviewers:
ericli, ericli1
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Re-adding get_site_job_data(): Now uses host platform for hostname. Update to CL http://codereview.chromium.org/6677136/ - Changing default keyval info with get_site_job_data() allows cleaner reporting and smaller tko_machines tables when multiple machines are used on the same job. Now hostname will only be updated in multimachine jobs when the platform of a host can be retrieved from AFE. The platform will be used as the hostname to prevent breaking the dashboard. Change-Id: I24c6a6937b583ca3d10f5c9bfb759346ae6a2b26 BUG=None. TEST=Tested multimachine BVT run in the lab. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9dc949c

Patch Set 1 #

Patch Set 2 : Get platform from keyval file instead of frontend. #

Total comments: 1

Patch Set 3 : Add a comment about all hosts sharing a platform. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
A server/site_server_job.py View 1 2 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pauldean_chromium
Hi Eric, Here is the update with platform as the hostname in multimachine jobs. Thanks, ...
9 years, 8 months ago (2011-04-06 17:56:24 UTC) #1
pauldean_chromium
Eric, Here's a revised version that reads the platform from the keyval file instead of ...
9 years, 8 months ago (2011-04-06 20:14:15 UTC) #2
ericli
9 years, 8 months ago (2011-04-06 20:20:57 UTC) #3
LGTM.

http://codereview.chromium.org/6805015/diff/4/server/site_server_job.py
File server/site_server_job.py (right):

http://codereview.chromium.org/6805015/diff/4/server/site_server_job.py#newco...
server/site_server_job.py:25: # Only modify hostname on multimachine jobs
add a comment here:
assume all machine in the job machines list have the same platform label.

Powered by Google App Engine
This is Rietveld 408576698