Issue 6805013: Add a missing handle for serialized scope info

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6805013: Add a missing handle for serialized scope info (Closed)

Created:
9 years, 8 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Add a missing handle for serialized scope info R=vegorov@chromium.org BUG=v8:1252 TEST=none Committed: http://code.google.com/p/v8/source/detail?r=7519

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -32 lines)			Patch
	M	src/scopes.h	View	1	3 chunks	+4 lines, -26 lines	0 comments	Download
	M	src/scopes.cc	View	1	5 chunks	+33 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Søren Thygesen Gjesse

Should we pass a handle in the constructor, or do you think this is OK ...

9 years, 8 months ago (2011-04-06 16:45:41 UTC) #1

Vyacheslav Egorov (Chromium)

LGTM Passing Handle into constructor might better convey the message that Scope is GC aware ...

9 years, 8 months ago (2011-04-06 16:52:46 UTC) #2

Søren Thygesen Gjesse

9 years, 8 months ago (2011-04-06 18:52:37 UTC) #3

Changed to pass handle into the constructor.