Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6567)

Unified Diff: chrome/browser/web_resource/web_resource_service.cc

Issue 6805008: Remove RDH from UtilityProcessHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix presubmit. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_resource/web_resource_service.cc
diff --git a/chrome/browser/web_resource/web_resource_service.cc b/chrome/browser/web_resource/web_resource_service.cc
index 717c85014a1e353c978d431f28e47775532746f3..1bd0393e182a39e44683b88d864f1a8f43586773 100644
--- a/chrome/browser/web_resource/web_resource_service.cc
+++ b/chrome/browser/web_resource/web_resource_service.cc
@@ -123,6 +123,8 @@ class WebResourceService::UnpackerClient
void Start() {
AddRef(); // balanced in Cleanup.
+ // TODO(willchan): Look for a better signal of whether we're in a unit test
+ // or not. Using |resource_dispatcher_host_| for this is pretty lame.
// If we don't have a resource_dispatcher_host_, assume we're in
// a test and run the unpacker directly in-process.
bool use_utility_process =
@@ -134,7 +136,6 @@ class WebResourceService::UnpackerClient
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
NewRunnableMethod(this, &UnpackerClient::StartProcessOnIOThread,
- web_resource_service_->resource_dispatcher_host_,
thread_id));
} else {
WebResourceUnpacker unpacker(json_data_);
@@ -178,9 +179,8 @@ class WebResourceService::UnpackerClient
Release();
}
- void StartProcessOnIOThread(ResourceDispatcherHost* rdh,
- BrowserThread::ID thread_id) {
- UtilityProcessHost* host = new UtilityProcessHost(rdh, this, thread_id);
+ void StartProcessOnIOThread(BrowserThread::ID thread_id) {
+ UtilityProcessHost* host = new UtilityProcessHost(this, thread_id);
// TODO(mrc): get proper file path when we start using web resources
// that need to be unpacked.
host->StartWebResourceUnpacker(json_data_);
« no previous file with comments | « chrome/browser/utility_process_host.cc ('k') | content/browser/in_process_webkit/indexed_db_key_utility_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698