Remove RDH from UtilityProcessHost.

chrome/browser/web_resource/web_resource_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/web_resource/web_resource_service.h"
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
@@ skipping 108 matching lines @@
     : web_resource_service_(web_resource_service),
       json_data_(json_data), got_response_(false) {
   }
 
   void Start() {
     AddRef();  // balanced in Cleanup.
 
     // If we don't have a resource_dispatcher_host_, assume we're in
     // a test and run the unpacker directly in-process.
     bool use_utility_process =
         web_resource_service_->resource_dispatcher_host_ != NULL &&

[jam, 2011/04/06 16:28:36]

looks like we don't need resource_dispatcher_host_ anymore.  we can use another
signal that we're running in a unit test

[willchan no longer on Chromium, 2011/04/06 16:37:25]

I was too lazy to do that. I'm happy to do it though, what's a better signal? I
didn't clean up the other place you mentioned due to this same problem, lack of
a signal that we're in a unit test. I have to admit using rdh is a pretty lame
signal :P

[jam, 2011/04/06 16:52:30]

hmm, good question :)  I guess we can still check
g_browser_process->resource_dispatcher_host(), or maybe slightly better, check
g_browser_process->io_thread()

[willchan no longer on Chromium, 2011/04/06 16:59:12]

I ran into an issue earlier where the extension code needed to pass RDH since
g_browser_process is only accessible on the UI thread. It's not clear to me that
this code here is running on the UI thread, although I do see that it posts to
the IO thread, so at least it's not on the IO thread :)

So it's possible I can fix this one, but I don't see a better signal for the
other place you commented on.

Hopefully it doesn't sound too lame, but maybe it's OK if I just leave a TODO
saying we really shouldn't be using this signal, and should find a different
signal instead? Using RDH or io_thread are both sorta lame, but I don't know
what's the best option here.

         !CommandLine::ForCurrentProcess()->HasSwitch(switches::kSingleProcess);
     if (use_utility_process) {
       BrowserThread::ID thread_id;
       CHECK(BrowserThread::GetCurrentThreadIdentifier(&thread_id));
       BrowserThread::PostTask(
           BrowserThread::IO, FROM_HERE,
           NewRunnableMethod(this, &UnpackerClient::StartProcessOnIOThread,
-                            web_resource_service_->resource_dispatcher_host_,
                             thread_id));
     } else {
       WebResourceUnpacker unpacker(json_data_);
       if (unpacker.Run()) {
         OnUnpackWebResourceSucceeded(*unpacker.parsed_json());
       } else {
         OnUnpackWebResourceFailed(unpacker.error_message());
       }
     }
   }
@@ skipping 23 matching lines @@
 
   // Release reference and set got_response_.
   void Cleanup() {
     if (got_response_)
       return;
 
     got_response_ = true;
     Release();
   }
 
-  void StartProcessOnIOThread(ResourceDispatcherHost* rdh,
-                              BrowserThread::ID thread_id) {
-    UtilityProcessHost* host = new UtilityProcessHost(rdh, this, thread_id);
+  void StartProcessOnIOThread(BrowserThread::ID thread_id) {
+    UtilityProcessHost* host = new UtilityProcessHost(this, thread_id);
     // TODO(mrc): get proper file path when we start using web resources
     // that need to be unpacked.
     host->StartWebResourceUnpacker(json_data_);
   }
 
   scoped_refptr<WebResourceService> web_resource_service_;
 
   // Holds raw JSON string.
   const std::string& json_data_;
 
@@ skipping 87 matching lines @@
 }
 
 void WebResourceService::UpdateResourceCache(const std::string& json_data) {
   UnpackerClient* client = new UnpackerClient(this, json_data);
   client->Start();
 
   // Set cache update time in preferences.
   prefs_->SetString(last_update_time_pref_name_,
       base::DoubleToString(base::Time::Now().ToDoubleT()));
 }