Don't store rietveld.extracc in git config.

Don't store rietveld.extracc in git config.

BUG=none
TEST=no more git config spam!

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80646

[Bernhard Bauer, 2011-04-06 10:51:18]

Please review.

[M-A Ruel, 2011-04-06 13:06:20]

I think this is the wrong fix.

The right fix is to remove the git config --replace-all rietveld.extracc call
and instead set a property on the ChangeList().

Then move Settings.GetCCList() to ChangeList.GetCCList() and to this call there.

[Bernhard Bauer, 2011-04-06 13:09:10]

On Wed, Apr 6, 2011 at 15:06,  <maruel@chromium.org> wrote:
> I think this is the wrong fix.
>
> The right fix is to remove the git config --replace-all rietveld.extracc
> call
> and instead set a property on the ChangeList().
>
> Then move Settings.GetCCList() to ChangeList.GetCCList() and to this call
> there.

Sounds good. I was just assuming there was a reason for caching this
in the config.

>
> http://codereview.chromium.org/6805007/
>

[M-A Ruel, 2011-04-06 13:10:43]

On 2011/04/06 13:09:10, Bernhard Bauer wrote:
> On Wed, Apr 6, 2011 at 15:06,  <mailto:maruel@chromium.org> wrote:
> > I think this is the wrong fix.
> >
> > The right fix is to remove the git config --replace-all rietveld.extracc
> > call
> > and instead set a property on the ChangeList().
> >
> > Then move Settings.GetCCList() to ChangeList.GetCCList() and to this call
> > there.
> 
> Sounds good. I was just assuming there was a reason for caching this
> in the config.

Historical reasons only. Don't assume anything done by the tools is sane. :D

[Bernhard Bauer, 2011-04-06 15:22:10]

On 2011/04/06 13:06:20, Marc-Antoine Ruel wrote:
> I think this is the wrong fix.
> 
> The right fix is to remove the git config --replace-all rietveld.extracc call
> and instead set a property on the ChangeList().
> 
> Then move Settings.GetCCList() to ChangeList.GetCCList() and to this call
there.

OK, done.

[M-A Ruel, 2011-04-06 16:45:11]

awesome, thanks a lot for doing that.

lgtm

[commit-bot: I haz the power, 2011-04-06 17:02:43]

Presubmit check for 6805007-2002 failed and returned exit status 1.

Running presubmit commit checks ...
************* Module git_cl
W0212:355:Changelist.GetCCList: Access to a protected member _GetConfig of a
client class
E0602:355:Changelist.GetCCList: Undefined variable 'setting'
E0602:567:GetCodereviewSettingsInteractively: Undefined variable 'cl'
Syncing rietveld...
Running push-basic.sh
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/verification/presubmit_shim.py", line 34, in
<module>
    sys.exit(presubmit_support.Main(None))
  File "/b/depot_tools/presubmit_support.py", line 1195, in Main
    options.may_prompt)
  File "/b/depot_tools/presubmit_support.py", line 1062, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 981, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 105, in CheckChangeOnCommit
  File "<string>", line 47, in CommonChecks
  File "<string>", line 88, in RunGitClTests
AttributeError: 'module' object has no attribute 'check_output'
Sending crash report ...
  exception: 'module' object has no attribute 'check_output'
  args: ['/mnt/data/b/commit-queue/verification/presubmit_shim.py', '--commit',
'--issue', '6805007', '--patchset', '2002', '--name', '6805007-2002',
'--description', 'Shorten rietveld.extracc git config value to less than 256
characters.\n\nOtherwise the git config can get trashed for very long
watchlists.\n\nBUG=none\nTEST=none\n', 'git_cl.py']
  stack:   File "/mnt/data/b/commit-queue/verification/pres
  host: vm105-m4.golo.chromium.org
  version: 2.6.5 (r265:79063, Apr 16 2010, 13:57:41) 
[GCC 4.
  user: chrome-bot
  cwd: /mnt/data/b/commit-queue/workdir/depot_tools
A stack trace has been sent to the maintainers.

[M-A Ruel, 2011-04-06 17:03:46]

On 2011/04/06 17:02:43, commit-bot wrote:
> Presubmit check for 6805007-2002 failed and returned exit status 1.

Yeah you'll have to commit it yourself, I'm fixing the tests as we speak so the
commit bot is super hosed.

[M-A Ruel, 2011-04-06 17:04:55]

Actually, please fix those:

W0212:355:Changelist.GetCCList: Access to a protected member _GetConfig of a
client class
E0602:355:Changelist.GetCCList: Undefined variable 'setting'
E0602:567:GetCodereviewSettingsInteractively: Undefined variable 'cl'

M-A

Le 6 avril 2011 13:03,  <maruel@chromium.org> a écrit :
> On 2011/04/06 17:02:43, commit-bot wrote:
>>
>> Presubmit check for 6805007-2002 failed and returned exit status 1.
>
> Yeah you'll have to commit it yourself, I'm fixing the tests as we speak so
> the
> commit bot is super hosed.
>
> http://codereview.chromium.org/6805007/
>

[Bernhard Bauer, 2011-04-06 17:33:27]

On Wed, Apr 6, 2011 at 19:04, Marc-Antoine Ruel <maruel@chromium.org> wrote:
> Actually, please fix those:
>
> W0212:355:Changelist.GetCCList: Access to a protected member _GetConfig of a
> client class
> E0602:355:Changelist.GetCCList: Undefined variable 'setting'
> E0602:567:GetCodereviewSettingsInteractively: Undefined variable 'cl'

Done. git cl presubmit on Linux machine is printing what looks like a
couple of thousand lines of errors though, so I'm not sure if
everything is working.

> M-A
>
> Le 6 avril 2011 13:03,  <maruel@chromium.org> a écrit :
>> On 2011/04/06 17:02:43, commit-bot wrote:
>>>
>>> Presubmit check for 6805007-2002 failed and returned exit status 1.
>>
>> Yeah you'll have to commit it yourself, I'm fixing the tests as we speak so
>> the
>> commit bot is super hosed.
>>
>> http://codereview.chromium.org/6805007/
>>
>