Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1442)

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 6805005: Fix opmitized external array access for compound assignments (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: remove unchanged file Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ia32/lithium-codegen-ia32.cc
diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc
index 3408256f2d0323a197632f7fbb616d677fbefc87..00a6821f5455d8d78de7187c50b11735ae28fa56 100644
--- a/src/ia32/lithium-codegen-ia32.cc
+++ b/src/ia32/lithium-codegen-ia32.cc
@@ -2311,6 +2311,7 @@ void LCodeGen::DoLoadKeyedSpecializedArrayElement(
DeoptimizeIf(negative, instr->environment());
break;
case kExternalFloatArray:
+ default:
Mads Ager (chromium) 2011/04/06 16:45:15 Why do you want a default case here? Isn't it bett
UNREACHABLE();
break;
}
@@ -2980,6 +2981,7 @@ void LCodeGen::DoStoreKeyedSpecializedArrayElement(
__ mov(Operand(external_pointer, key, times_4, 0), value);
break;
case kExternalFloatArray:
+ default:
Mads Ager (chromium) 2011/04/06 16:45:15 Ditto.
UNREACHABLE();
break;
}

Powered by Google App Engine
This is Rietveld 408576698