Debugger: show local scope before with in scope chain for functions created inside with block

Debugger: show local scope before with for functions created inside with block
Committed: http://code.google.com/p/v8/source/detail?r=7518

[yurys, 2011-04-06 16:31:46]

Debugger: show local scope before with in scope chain for functions created
inside with block. E.g. in the following script
with({x: 1}) { (function(x) { debugger;  })(2); } debugger should return Local
scope object before With one.

Corresponding Chromium issue:
http://code.google.com/p/chromium/issues/detail?id=70065

[antonm, 2011-04-06 16:41:49]

LGTM, but let's wait for Søren's comments as well.

http://codereview.chromium.org/6804015/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6804015/diff/1/src/runtime.cc#newcode9825
src/runtime.cc:9825: // The context_ is a with block from the outer function.
maybe assert this: ASSRT(context_->has_extension())?

http://codereview.chromium.org/6804015/diff/1/test/mjsunit/debug-scopes.js
File test/mjsunit/debug-scopes.js (right):

http://codereview.chromium.org/6804015/diff/1/test/mjsunit/debug-scopes.js#ne...
test/mjsunit/debug-scopes.js:148: if
(!scope.scopeObject().property('').isUndefined()) {
just curious, what are those properties with empty names?

[Søren Thygesen Gjesse, 2011-04-06 16:51:11]

LGTM

[yurys, 2011-04-06 17:41:15]

Added a couple more tests.

On 2011/04/06 16:41:49, antonm wrote:
> LGTM, but let's wait for Søren's comments as well.
> 
> http://codereview.chromium.org/6804015/diff/1/src/runtime.cc
> File src/runtime.cc (right):
> 
> http://codereview.chromium.org/6804015/diff/1/src/runtime.cc#newcode9825
> src/runtime.cc:9825: // The context_ is a with block from the outer function.
> maybe assert this: ASSRT(context_->has_extension())?
> 
Done.

> http://codereview.chromium.org/6804015/diff/1/test/mjsunit/debug-scopes.js
> File test/mjsunit/debug-scopes.js (right):
> 
>
http://codereview.chromium.org/6804015/diff/1/test/mjsunit/debug-scopes.js#ne...
> test/mjsunit/debug-scopes.js:148: if
> (!scope.scopeObject().property('').isUndefined()) {
> just curious, what are those properties with empty names?
Have no idea, but in case 
function closure_in_with_2() {
  with({x:1}) {
    (function inner(x) {
      with({x:3}) {
        debugger;
      }
    })(2);
  }
}
properties of local scope of function 'inner' will contain a property with empty
name and value the function itself. We may want to hide such properties from
debugger clients but then we should do the same with .catch-var