Issue 6804001: AU: Lower HTTP timeout on official builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6804001: AU: Lower HTTP timeout on official builds. (Closed)

Created:
9 years, 8 months ago by adlr

Modified:
9 years ago

Reviewers:
gauravsh

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
http://git.chromium.org/git/update_engine.git@master

Visibility:
Public.

Description

AU: Lower HTTP timeout on official builds. We grew the timeout from 90s to 3 min a while back to give developers more time to let the dev server build images. Unfortunately, this means official builds take longer to time out when they have a bad HTTP connection. This CL restores the 90s timeout on official builds. BUG=chromium-os:13793 TEST=on device testing Change-Id: Ia7a6474331770b3db3425147921d24077452c097 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2a0fd74

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	libcurl_http_fetcher.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

adlr

One more review, if you don't mind. This one is also very hard to unittest ...

9 years, 8 months ago (2011-04-06 01:59:58 UTC) #1

lgtm

Expand Messages | Collapse Messages