Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Unified Diff: chrome/browser/desktop_notification_handler.cc

Issue 6803012: Profile shouldn't own DesktopNotificationService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/desktop_notification_handler.cc
diff --git a/chrome/browser/desktop_notification_handler.cc b/chrome/browser/desktop_notification_handler.cc
index 8bd2ef2ab5381112ea487b575b4b644eaaadf385..986425a615c42f23910a8f1dbfcb3f472999db03 100644
--- a/chrome/browser/desktop_notification_handler.cc
+++ b/chrome/browser/desktop_notification_handler.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/desktop_notification_handler.h"
#include "chrome/browser/notifications/desktop_notification_service.h"
+#include "chrome/browser/notifications/desktop_notification_service_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "content/browser/renderer_host/render_process_host.h"
#include "content/browser/renderer_host/render_view_host.h"
@@ -38,7 +39,7 @@ void DesktopNotificationHandler::OnShow(
const DesktopNotificationHostMsg_Show_Params& params) {
RenderProcessHost* process = render_view_host()->process();
DesktopNotificationService* service =
- process->profile()->GetDesktopNotificationService();
+ DesktopNotificationServiceFactory::GetForProfile(process->profile());
service->ShowDesktopNotification(
params,
@@ -50,7 +51,7 @@ void DesktopNotificationHandler::OnShow(
void DesktopNotificationHandler::OnCancel(int notification_id) {
RenderProcessHost* process = render_view_host()->process();
DesktopNotificationService* service =
- process->profile()->GetDesktopNotificationService();
+ DesktopNotificationServiceFactory::GetForProfile(process->profile());
service->CancelDesktopNotification(
process->id(),
@@ -67,7 +68,7 @@ void DesktopNotificationHandler::OnRequestPermission(
RenderProcessHost* process = render_view_host()->process();
DesktopNotificationService* service =
- process->profile()->GetDesktopNotificationService();
+ DesktopNotificationServiceFactory::GetForProfile(process->profile());
service->RequestPermission(
source_origin, process->id(), routing_id(), callback_context, NULL);
}

Powered by Google App Engine
This is Rietveld 408576698