chrome/browser/chromeos/notifications/balloon_view.cc - Issue 6803012: Profile shouldn't own DesktopNotificationService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/notifications/balloon_view.cc

Issue 6803012: Profile shouldn't own DesktopNotificationService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/notifications/balloon_view.cc

diff --git a/chrome/browser/chromeos/notifications/balloon_view.cc b/chrome/browser/chromeos/notifications/balloon_view.cc

index cac419acf4798045de3ddb2024ee05926f298482..6246e517c5a91cac8908c08d344749de4c2d3380 100644

--- a/chrome/browser/chromeos/notifications/balloon_view.cc

+++ b/chrome/browser/chromeos/notifications/balloon_view.cc

@@ -12,6 +12,7 @@

#include "chrome/browser/chromeos/notifications/notification_panel.h"

#include "chrome/browser/notifications/balloon.h"

#include "chrome/browser/notifications/desktop_notification_service.h"

+#include "chrome/browser/notifications/desktop_notification_service_factory.h"

#include "chrome/browser/notifications/notification.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/views/notifications/balloon_view_host.h"

@@ -338,7 +339,7 @@ void BalloonViewImpl::DelayedClose(bool by_user) {

void BalloonViewImpl::DenyPermission() {

DesktopNotificationService* service =

- balloon_->profile()->GetDesktopNotificationService();

+ DesktopNotificationServiceFactory::GetForProfile(balloon_->profile());

service->DenyPermission(balloon_->notification().origin_url());

}

« no previous file with comments | « no previous file | chrome/browser/content_settings/content_settings_notification_provider.cc » ('j') | no next file with comments »