Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: content/browser/tab_contents/tab_contents.cc

Issue 6803012: Profile shouldn't own DesktopNotificationService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix dependency manager unit test Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/tab_contents.cc
diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc
index 65294b8a70e45a4d56672989e302d3a97f8fd4f6..d58b7d3f89f666361efc6b4eac2fc94023abddc3 100644
--- a/content/browser/tab_contents/tab_contents.cc
+++ b/content/browser/tab_contents/tab_contents.cc
@@ -36,6 +36,7 @@
#include "chrome/browser/metrics/metric_event_duration_details.h"
#include "chrome/browser/metrics/user_metrics.h"
#include "chrome/browser/notifications/desktop_notification_service.h"
+#include "chrome/browser/notifications/desktop_notification_service_factory.h"
#include "chrome/browser/omnibox_search_hint.h"
#include "chrome/browser/pdf_unsupported_feature.h"
#include "chrome/browser/platform_util.h"
@@ -2401,7 +2402,7 @@ void TabContents::WorkerCrashed() {
void TabContents::RequestDesktopNotificationPermission(
const GURL& source_origin, int callback_context) {
DesktopNotificationService* service =
- profile()->GetDesktopNotificationService();
+ DesktopNotificationServiceFactory::GetForProfile(profile());
service->RequestPermission(
source_origin, GetRenderProcessHost()->id(),
render_view_host()->routing_id(), callback_context, this);

Powered by Google App Engine
This is Rietveld 408576698