chrome/browser/extensions/notifications_apitest.cc - Issue 6803012: Profile shouldn't own DesktopNotificationService.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/notifications_apitest.cc

Issue 6803012: Profile shouldn't own DesktopNotificationService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/extension_apitest.h"	5 #include "chrome/browser/extensions/extension_apitest.h"

6	6

7 #include "chrome/browser/notifications/desktop_notification_service.h"	7 #include "chrome/browser/notifications/desktop_notification_service.h"

	8 #include "chrome/browser/notifications/desktop_notification_service_factory.h"

8 #include "chrome/browser/profiles/profile.h"	9 #include "chrome/browser/profiles/profile.h"

9 #include "chrome/browser/ui/browser.h"	10 #include "chrome/browser/ui/browser.h"

10	11

11 // Flaky, http://crbug.com/42314.	12 // Flaky, http://crbug.com/42314.

12 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, FLAKY_Notifications) {	13 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, FLAKY_Notifications) {

13 #if defined(OS_LINUX) && defined(TOOLKIT_VIEWS)	14 #if defined(OS_LINUX) && defined(TOOLKIT_VIEWS)

14 // Notifications not supported on linux/views yet.	15 // Notifications not supported on linux/views yet.

15 #else	16 #else

16 ASSERT_TRUE(RunExtensionTest("notifications/has_not_permission")) << message_;	17 ASSERT_TRUE(RunExtensionTest("notifications/has_not_permission")) << message_;

17 ASSERT_TRUE(RunExtensionTest("notifications/has_permission_manifest"))	18 ASSERT_TRUE(RunExtensionTest("notifications/has_permission_manifest"))

18 << message_;	19 << message_;

19 browser()->profile()->GetDesktopNotificationService()	20 DesktopNotificationServiceFactory::GetForProfile(browser()->profile())

20 ->GrantPermission(GURL(	21 ->GrantPermission(GURL(

21 "chrome-extension://peoadpeiejnhkmpaakpnompolbglelel"));	22 "chrome-extension://peoadpeiejnhkmpaakpnompolbglelel"));

22 ASSERT_TRUE(RunExtensionTest("notifications/has_permission_prefs"))	23 ASSERT_TRUE(RunExtensionTest("notifications/has_permission_prefs"))

23 << message_;	24 << message_;

24 #endif	25 #endif

25 }	26 }

26

OLD	NEW

« no previous file with comments | « chrome/browser/desktop_notification_handler.cc ('k') | chrome/browser/notifications/desktop_notification_service.h » ('j') | no next file with comments »