third_party/libphonenumber/README.chromium - Issue 6803005: Autofill phone number enhancements and integration of Phone Number Util Library: part 1

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libphonenumber/README.chromium

Issue 6803005: Autofill phone number enhancements and integration of Phone Number Util Library: part 1 (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 Name: International Phone Number Library

	2 Short Name: libphonenumber

	3 URL: http://libphonenumber.googlecode.com/svn/trunk/

	4 Version: unknown

	5 Revision: r170

	6 Security Critical: yes

	7

	8 This directory contains the source code of international phone number library
	Mark Mentovai 2011/04/27 16:53:01 Is “international phone number library” a proper n Is “international phone number library” a proper name? Then capitalize it. If you’re just using it as a descriptive term, this should say “source code of an international phone number library.” GeorgeY 2011/04/28 07:21:18 Done. Show quoted text On 2011/04/27 16:53:01, Mark Mentovai wrote: > Is “international phone number library” a proper name? Then capitalize it. > > If you’re just using it as a descriptive term, this should say “source code of > an international phone number library.” Done.
	9 for C/C++.

	10

	11 This library depends on
	dhollowa 2011/04/27 16:11:57 Let's add a directory called "patches" and add the Let's add a directory called "patches" and add the re-adaptor patch to the directory. We should apply the patch to the local contents as well. Documentation for the patch should be added to this file. Please see third_party/icu/README.chromium and third_party/icu/patches for examples. GeorgeY 2011/04/28 07:21:18 Done. Show quoted text On 2011/04/27 16:11:57, dhollowa wrote: > Let's add a directory called "patches" and add the re-adaptor patch to the > directory. We should apply the patch to the local contents as well. > > Documentation for the patch should be added to this file. Please see > third_party/icu/README.chromium and third_party/icu/patches for examples. Done.
	12 1. base/ for types, scoped_ptr's, etc.

	13 2. third_party/icu for internationalisation, UTF8-16-32 conversion and regular

	14 expressions.
	Mark Mentovai 2011/04/27 16:53:01 This line could use a little line-up-with-the-one- This line could use a little line-up-with-the-one-above-it love. GeorgeY 2011/04/28 07:21:18 Done. Show quoted text On 2011/04/27 16:53:01, Mark Mentovai wrote: > This line could use a little line-up-with-the-one-above-it love. Done.
	15 3. third_party/protobuf Lite version.

	16

	17 Additional files, not in the original library:

	18 libphonenumber.gyp

	19 README.chromium

	20 chrome\regexp_adapter_icuregexp.cc
	Mark Mentovai 2011/04/27 16:53:01 You used slashes in the text above but a backslash You used slashes in the text above but a backslash here. Standardize on forward slashes. GeorgeY 2011/04/28 07:21:18 Done. Show quoted text On 2011/04/27 16:53:01, Mark Mentovai wrote: > You used slashes in the text above but a backslash here. Standardize on forward > slashes. Done.
	21
	Mark Mentovai 2011/04/27 16:53:01 Get rid of the blank lines at the end of this file Get rid of the blank lines at the end of this file. GeorgeY 2011/04/28 07:21:18 Done. Show quoted text On 2011/04/27 16:53:01, Mark Mentovai wrote: > Get rid of the blank lines at the end of this file. Done.
	22

OLD	NEW

« DEPS ('K') | « chrome/chrome_browser.gypi ('k') | third_party/libphonenumber/chrome/regexp_adapter_icuregexp.cc » ('j') | third_party/libphonenumber/chrome/regexp_adapter_icuregexp.cc » ('J')